[C++] FixedSizeListBuilder should have UnsafeAppend methods #45723 #46126
+22
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR? I added the three UnsafeAppend methods for FixedSizeListBuilder and replaced
instances in three files to call UnsafeAppend instead of regular append. Files changed were: scalar_nested.cc, fixed_width_test_util.cc, and scalar_string_ascii.cc, along with the header and cc file where functions were declared/defined.
Are these changes tested? Upon each change, I recompiled and rebuilt the program and tested with ctest. Through my testing, everything seemed to be working as usual.
Are there any user-facing changes?