GH-46574: [C++][FlightRPC] ODBC Driver Connectivity support #47971

alinaliBQ · 2025-10-27T23:32:09Z

Rationale for this change

Add ODBC driver connection support for the driver, so the driver can connect to servers.

What changes are included in this PR?

Implementation of unicode APIs:

SQLDriverConnect
SQLDisconnect
SQLConnect
DSN Window
Test refactoring

Are these changes tested?

Tested locally on Windows.
Note that this PR depends on #47763 to get tests passing.

Are there any user-facing changes?

N/A

GitHub Issue: [C++][Arrow Flight SQL ODBC] Develop basic connectivity: SQLDriverConnect, SQLConnect, and SQLDisconnect, and DSN window #46574

github-actions · 2025-10-27T23:32:34Z

⚠️ GitHub issue #46574 has been automatically assigned in GitHub to PR creator.

cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc

alinaliBQ · 2025-10-28T22:31:55Z

@lidavidm @kou Changes in this PR are ready for review, please let me know if you have any comments. Thank you! This PR is in draft because it depends on #47763 to get 2 of its tests passing.

* use suggestion from James for one-liner change to return `Status::OK` directly * fix for iterating endpoints, it is based on JDBC's fix for the same bug * save value of `FlightClientOptions` * Use `TestFlightServer` Add `arrow_flight_sql_shared` to enable usages for `TestFlightServer` * Fix build errors from missing `gmock` * Add checks for array data Update flight_sql_stream_chunk_buffer_test.cc Add `FlightStreamChunkBufferTest` unit test Draft test with `FlightSQLODBCMockEndpointTestBase` * Reference apacheGH-47117 and Clean up code * Add driver and DSN to built-in properties to not pass driver/dsn as attributes to server * Allow `=` in values inside connection strings, fixes connectivity problems * Address comments from Rob

* SQLDriverConnect requires SQLGetInfo to be implemented for tests to pass, because driver manager requires SQLGetInfo Co-Authored-By: alinalibq <[email protected]>

Co-authored-by: justing-bq <[email protected]>

alinaliBQ · 2025-10-29T18:36:31Z

Rebased onto master to get changes from #47763

Edit: getting segfault error, looking into it.

Iirc, there is segfault error associated with `SQLGetStmtAttrW` Attempt to fix segfault error by adding impl for `SQLSetConnectAttr` Part-fix remove `using` that isn't needed

lidavidm · 2025-10-31T01:09:13Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/system_dsn.h

 #include "arrow/flight/sql/odbc/odbc_impl/platform.h"

 #include "arrow/flight/sql/odbc/odbc_impl/config/configuration.h"
+#include "arrow/result.h"


nit: if you wanted arrow::Status, just include status.h

lidavidm · 2025-10-31T01:10:13Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_connection.h

 namespace arrow::flight::sql::odbc {

+/// \brief Case insensitive comparator that takes string_view
+struct CaseInsensitiveComparatorStrView {


Why is this defined here? It seems to only be used inside the implementation

lidavidm · 2025-10-31T01:13:52Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/spi/connection.h


 // PropertyMap is case-insensitive for keys.
-typedef std::map<std::string_view, std::string, CaseInsensitiveComparator> PropertyMap;
+typedef std::map<std::string, std::string, CaseInsensitiveComparator> PropertyMap;


With the right definitions, you should be able to avoid wrapping every lookup in std::string. Can we avoid that? (See the note about 'transparent' comparator in https://en.cppreference.com/w/cpp/container/map/find)

lidavidm · 2025-10-31T01:19:12Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/attribute_utils.h

+#include "arrow/flight/sql/odbc/odbc_impl/exceptions.h"
+#include "arrow/flight/sql/odbc/odbc_impl/platform.h"

 namespace ODBC {


(maybe for a separate issue but) can we fix this namespace?

yea we can do it for a separate issue. Are we thinking of replacing ODBC with namespace arrow::flight::sql::odbc?

lidavidm · 2025-10-31T01:22:04Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/encoding_utils.h

 // Return the number of bytes required for the conversion.
 template <typename CHAR_TYPE>
-inline size_t ConvertToSqlWChar(const std::string& str, SQLWCHAR* buffer,
+inline size_t ConvertToSqlWChar(const std::string_view& str, SQLWCHAR* buffer,


string_view can (and should) be passed by value.

lidavidm · 2025-10-31T01:22:49Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/encoding_utils.h

 /// \return wchar_msg in std::string format
 inline std::string SqlWcharToString(SQLWCHAR* wchar_msg, SQLINTEGER msg_len = SQL_NTS) {
-  if (msg_len == 0 || !wchar_msg || wchar_msg[0] == 0) {
+  if (!wchar_msg || wchar_msg[0] == 0 || msg_len == 0) {


Shouldn't you check length before dereferencing the pointer?

lidavidm · 2025-10-31T01:23:57Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_connection.h

-  static std::string GetPropertiesFromConnString(
+  /// @return the DSN or an empty string if the DSN is not found or is found after the
+  /// driver
+  static std::string GetDsnIfExists(const std::string& conn_str);


Would std::optional<std::string> be better?

lidavidm · 2025-10-31T01:27:28Z

cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_connection.h

+  /// @return the DSN or an empty string if the DSN is not found or is found after the
+  /// driver


We use \return not @return.

lidavidm · 2025-10-31T01:27:57Z

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

+#if defined _WIN32
+// For displaying DSN Window
+#  include "arrow/flight/sql/odbc/odbc_impl/system_dsn.h"
+#endif


Suggested change

#endif

#endif // defined(_WIN32)

github-actions bot added Component: C++ Component: FlightRPC awaiting review Awaiting review labels Oct 27, 2025

alinaliBQ mentioned this pull request Oct 27, 2025

GH-46575: [C++][FlightRPC] Add Diagnostic tests #47764

Draft

alinaliBQ commented Oct 27, 2025

View reviewed changes

cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc Show resolved Hide resolved

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 27, 2025

alinaliBQ force-pushed the gh-46574-driver-connectivity branch 2 times, most recently from f28ed1f to 8ad5b6a Compare October 28, 2025 22:29

alinaliBQ and others added 4 commits October 29, 2025 11:12

Extract SQLDriverConnect implementation

156c42c

* SQLDriverConnect requires SQLGetInfo to be implemented for tests to pass, because driver manager requires SQLGetInfo Co-Authored-By: alinalibq <[email protected]>

Add connection tests and refactoring

a89cfc5

Co-authored-by: justing-bq <[email protected]>

Port test fixture changes

a90c2c2

Co-authored-by: justing-bq <[email protected]>

Fix connectivity issues from headers

fc95da6

alinaliBQ force-pushed the gh-46574-driver-connectivity branch from b5159a7 to fc95da6 Compare October 29, 2025 18:35

alinaliBQ marked this pull request as ready for review October 29, 2025 18:36

alinaliBQ requested a review from lidavidm as a code owner October 29, 2025 18:36

alinaliBQ marked this pull request as draft October 29, 2025 20:42

Attempt to fix segfault error

53cf1c9

Iirc, there is segfault error associated with `SQLGetStmtAttrW` Attempt to fix segfault error by adding impl for `SQLSetConnectAttr` Part-fix remove `using` that isn't needed

lidavidm reviewed Oct 31, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Oct 31, 2025

alinaliBQ mentioned this pull request Oct 31, 2025

[C++] Segmentation fault at SparseUnionType destructor when arrow.dll is unloaded #48019

Open

		/// @return the DSN or an empty string if the DSN is not found or is found after the
		/// driver

GH-46574: [C++][FlightRPC] ODBC Driver Connectivity support #47971

Are you sure you want to change the base?

GH-46574: [C++][FlightRPC] ODBC Driver Connectivity support #47971

Conversation

alinaliBQ commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

Uh oh!

alinaliBQ commented Oct 28, 2025

Uh oh!

alinaliBQ commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alinaliBQ commented Oct 27, 2025 •

edited

Loading

alinaliBQ commented Oct 29, 2025 •

edited

Loading