Skip to content

Bump org.apache.xmlbeans:xmlbeans from 3.0.1 to 5.3.0; rhino to 1.8.0 #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Bump org.apache.xmlbeans:xmlbeans from 3.0.1 to 5.3.0; rhino to 1.8.0 #980

wants to merge 7 commits into from
+115 −94

Conversation

lgayard-brex
Copy link

Bump org.apache.xmlbeans:xmlbeans from 3.0.1 to 5.3.0
Bump org.mozilla:rhino to 1.8.0, as fix to scripting module

  • Introduces org.mozilla:rhino-xml, from more recent 1.8.0

Fix scripting module compatibility with XMLBeans 5.3.0

  • Updates JSOMElementConvertor to handle XMLBeans 5.3.0 API changes
  • Adds fallback mechanisms for getXmlObject() method removal

dependabot bot and others added 3 commits August 14, 2025 18:07
@dependabot @lgayard-brex
Bump org.apache.xmlbeans:xmlbeans from 3.0.1 to 5.3.0
a1f23b4
@lgayard-brex
Fix scripting module compatibility with XMLBeans 5.3.0
8770c0d 
- Update JSOMElementConvertor to handle XMLBeans 5.3.0 API changes
- Add fallback mechanisms for getXmlObject() method removal
- Implement string-based XML parsing as ultimate fallback
- Normalize XML whitespace to fix test assertions
- Maintain backward compatibility with older XMLBeans versions
@lgayard-brex
Bump dependency on rhino to 1.8.0
3128b5e
@lgayard-brex lgayard-brex mentioned this pull request Aug 14, 2025
Draft
@cortlepp
Copy link
Member

Hey, thank you for looking into this! It seems like some code in xmlbeans-codegen still relies on the old xmlbeans version.

https://github.com/apache/axis-axis2-java-core/actions/runs/16973699000/job/48160085813?pr=980

@cortlepp
refactor: remove javaversion check
a2ccccd 
- xmlbeans no longer supports the GENERATE_JAVA_VERSION attribute, i.e. the constant still exists but is not referenced and there is no way to set it with the new API
@cortlepp
refactor: code cleanup, introduce generics
1afcdae
@cortlepp
Copy link
Member

Hey, thank you for looking into this! It seems like some code in xmlbeans-codegen still relies on the old xmlbeans version.

https://github.com/apache/axis-axis2-java-core/actions/runs/16973699000/job/48160085813?pr=980

I just noticed that I had already fixed at least some of those errors in my PR. I pushed them now (i hope you don't mind), we'll see if CI passes now.

@lgayard-brex lgayard-brex requested a review from cortlepp August 21, 2025 13:10
@lgayard-brex
Copy link
Author

Hey, thank you for looking into this! It seems like some code in xmlbeans-codegen still relies on the old xmlbeans version.
https://github.com/apache/axis-axis2-java-core/actions/runs/16973699000/job/48160085813?pr=980

I just noticed that I had already fixed at least some of those errors in my PR. I pushed them now (i hope you don't mind), we'll see if CI passes now.

Thank you for that. Hopefully, we're closer to getting this PR merged.

@lgayard-brex
scripting: assume XMLBeans 5.x, replace call to getXmlObject with toX…
52303e7 
…MLString

Removes field scope from class JSOMElementConvertor. This field was created within an enter/exit block in the constructor, but after the exit block, its state was invalid.

Reduces try/catch scope when parsing xml object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlazarski robertlazarski Awaiting requested review from robertlazarski

@cortlepp cortlepp Awaiting requested review from cortlepp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgayard-brex @cortlepp