-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RRIO] [Throttle] [Cache] Implement Throttle and Cache using an external resource. #29401
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
R: @m-trieu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. First set of comments, not yet go through tests
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/CacheTestIT.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/CallTest.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/EchoITOptions.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Cache.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java
Show resolved
Hide resolved
...a/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ThrottleWithExternalResource.java
Outdated
Show resolved
Hide resolved
...a/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ThrottleWithExternalResource.java
Outdated
Show resolved
Hide resolved
...a/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ThrottleWithExternalResource.java
Outdated
Show resolved
Hide resolved
...a/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ThrottleWithExternalResource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think @NonNull
is needed everywhere, just need to mark when nullable with annotation or option type.
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Cache.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Cache.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/RedisClient.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, also went through the tests. LGTM when previous two comments (static member; teardown) resolved
This PR closes #28932 , closes #28924, closes #28922, closes #28908, closes #28907 implementing all transforms that utilize an external resource. This PR is able to close many issues as it was realized that much can be implemented reusing the existing Call PTransform.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.