Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpc_version dependency #29511

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Nov 21, 2023

This PR fixes #29512 bumping the grpc_version to 1.59.0.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Nov 21, 2023
@damondouglas
Copy link
Contributor Author

Run Java PreCommit

@damondouglas
Copy link
Contributor Author

Run Java_GCP_IO_Direct PreCommit

@damondouglas
Copy link
Contributor Author

Run Python_Coverage PreCommit

@shunping
Copy link
Contributor

Failed tests are all from Jenkins and they should already be covered by the corresponding github actions.

@bvolpato
Copy link
Contributor

nit typo in title depencency -> dependency

@damondouglas damondouglas marked this pull request as ready for review November 21, 2023 22:33
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damondouglas damondouglas changed the title Bump grpc_version depencency Bump grpc_version dependency Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (444e10d) 37.85% compared to head (aaee776) 37.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #29511   +/-   ##
=======================================
  Coverage   37.85%   37.85%           
=======================================
  Files         690      690           
  Lines      101307   101307           
=======================================
  Hits        38353    38353           
  Misses      61362    61362           
  Partials     1592     1592           
Flag Coverage Δ
python 29.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvolpato
Copy link
Contributor

Run Java_IOs_Direct PreCommit

@bvolpato
Copy link
Contributor

Run Java_PVR_Flink_Batch PreCommit

@ahmedabu98
Copy link
Contributor

Run PostCommit_Java_Dataflow

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damondouglas damondouglas merged commit 09a2cfc into apache:master Nov 22, 2023
@damondouglas damondouglas deleted the upgrade-grpc-version-to-match-google-cloud-libraries-bom branch November 22, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: grpc_version in BeamModulePlugin not consistent with google_cloud_platform_libraries_bom
4 participants