-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataflow Streaming] Add Channelz staus page exporting GRPC channelz data #30211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R: @scwhittle |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
267f5c1
to
48579d7
Compare
16 tasks
scwhittle
requested changes
Feb 6, 2024
...ava/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/ChannelzServlet.java
Outdated
Show resolved
Hide resolved
...ava/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/ChannelzServlet.java
Outdated
Show resolved
Hide resolved
...ava/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/ChannelzServlet.java
Outdated
Show resolved
Hide resolved
...ava/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/ChannelzServlet.java
Outdated
Show resolved
Hide resolved
Run PreCommit |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
org.apache.beam:beam-vendor-grpc-1_60_1:0.2 is released and this is ready to get merged. |
0719de7
to
991fc86
Compare
Run Java PreCommit |
2 similar comments
Run Java PreCommit |
Run Java PreCommit |
scwhittle
requested changes
Feb 16, 2024
...a/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/WorkerStatusPages.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/ChannelzServlet.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/ChannelzServlet.java
Show resolved
Hide resolved
scwhittle
reviewed
Feb 16, 2024
.../main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/ChannelzServlet.java
Outdated
Show resolved
Hide resolved
scwhittle
requested changes
Feb 16, 2024
.../main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/ChannelzServlet.java
Show resolved
Hide resolved
scwhittle
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.