Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Increase timeouts in CallTest to reduce flakiness" #33807

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 30, 2025

Reverts #33775

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@scwhittle
Copy link
Contributor

It's flaky the other way too, I'm guessing the new failure is due to test timeout. So perhaps a timeout in the middle and/or increasing the test timeout would make this not flake. But reverting for now since it got worse.

@scwhittle scwhittle merged commit 5da82e7 into master Jan 30, 2025
23 checks passed
@Abacn Abacn deleted the revert-33775-flaky branch January 30, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants