Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#31438] Non-processing time triggers pass w/accumulation. #33881

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Feb 5, 2025

  • Effectively makes all aggregation transforms (AKA, GBKs) stateful.
  • Adds all non-processing time derived triggers.
  • Adds support for Accumulation mode.
  • Adds computation of panes for the triggered aggregation results.
  • Handles trigger edge case WRT Lifted combines and ElementCount triggers by disabling lifting when one is detected.
  • Added some of the Go trigger tests to the engine_test.go file, to maintain coverage.

Important notes: Does not support processing time triggers, or triggered side inputs or triggers against merging windows at this PR. Those will be supported at a later PR.

Blocks submission of Processing Time triggers at this time.

Increases the number of Java Validates Runner tests that pass from 325 to 336.

Part of #31438.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor

assign to next reviewer

@lostluck
Copy link
Contributor Author

lostluck commented Feb 5, 2025

R: @kennknowles @damccorm

As much as I'd love for Jack to look at this as well, he's doing the release and is busy enough.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@kennknowles
Copy link
Member

I took a quick pass and concluded that I will need some time. This one goes more into Prism details that I am not familiar with than the last one. It might be good for this to be a sit-down review with someone that you want to education about Prism's codebase.

@lostluck
Copy link
Contributor Author

lostluck commented Feb 6, 2025

You're not wrong, but at this point there's unlikely to be a specific person to get this education, due to circumstances.

For broad strokes of how it works, it is why I wrote the deep dive, which will need an adjustment for the side channel injected bundles.

https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/runners/prism/internal/README.md

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly lgtm - I had some minor questions/comments

Copy link
Contributor Author

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made. Also added the final "gate" WRT Stateful triggers with merging windows.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM once checks pass

@lostluck
Copy link
Contributor Author

Thanks for the review!

At this stage the next best move is to separate the different stage types, now that there's clarity in how each needs to function. It's fine when there are two different kinds (stateful and not stateful), but aggregation adds sufficient complexity that this won't be as maintainable without much care and reading to know which cyclomatic clause you're dealing with.

@lostluck lostluck merged commit 6fcf161 into apache:master Feb 11, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants