Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for collections.abc.Sequence #33999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msuozzo
Copy link

@msuozzo msuozzo commented Feb 15, 2025

Work towards #29135

Notes:

  • The naming used for the TypeConstraint is necessary to avoid colliding with
    the existing base class used for other collections.abc generics.
  • The change in transforms/stats.py is required due to a test failure that
    appears to require int be a valid param instead of Sequence[int].

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Work towards apache#29135

Notes:
- The naming used for the TypeConstraint is necessary to avoid colliding with
  the existing base class used for other collections.abc generics.
- The change in transforms/stats.py is required due to a test failure that
  appears to require `int` be a valid param instead of `Sequence[int]`.
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant