Fix Java GCP-IO Direct job #34019
Fix Java GCP-IO Direct job #34019
Conversation
|
R: @ahmedabu98 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
| @@ -50,7 +49,7 @@ public class RampupThrottlingFnTest { | |||
| @Mock private Counter mockCounter; | |||
| private final Sleeper mockSleeper = | |||
| millis -> { | |||
| verify(mockCounter).inc(millis); | |||
There was a problem hiding this comment.
would you mind explaining a little bit how this fixed the flaky test
There was a problem hiding this comment.
verify expected exactly one call, but sometimes the code retries and calls inc(millis) multiple times causing the test to fail.
| @@ -131,7 +131,15 @@ public static Iterable<Object[]> data() { | |||
| private static final int ORIGINAL_N = 60; | |||
| // for dynamic destination test | |||
| private static final int NUM_DESTINATIONS = 3; | |||
| private static final int TOTAL_NUM_STREAMS = 9; | |||
There was a problem hiding this comment.
R: @ahmedabu98 who took care of SchemaUpdate tests
There was a problem hiding this comment.
@akashorabek can we set TOTAL_NUM_STREAMS=6 and SCHEMA_UPDATE_TRIGGER=2? I worry we might be missing some unknown edge cases by restricting it too much
There was a problem hiding this comment.
@ahmedabu98 done
| @@ -131,7 +131,15 @@ public static Iterable<Object[]> data() { | |||
| private static final int ORIGINAL_N = 60; | |||
| // for dynamic destination test | |||
| private static final int NUM_DESTINATIONS = 3; | |||
| private static final int TOTAL_NUM_STREAMS = 9; | |||
There was a problem hiding this comment.
@akashorabek can we set TOTAL_NUM_STREAMS=6 and SCHEMA_UPDATE_TRIGGER=2? I worry we might be missing some unknown edge cases by restricting it too much
Fix java gcp io direct job
Fixes: #33909
Successful run example: https://github.com/akashorabek/beam/actions/runs/13397067650
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.