Skip to content

Conversation

@Arunodoy18
Copy link

This commit adds support for escaping and unescaping glob wildcard characters in file path specifications, addressing the issue where files with literal glob metacharacters (*, ?, {, }) in their names cannot be matched.

Changes:

  • Added escapeGlobWildcards(String spec) method to escape glob metacharacters by prefixing them with backslash
  • Added unescapeGlobWildcards(String spec) method to remove backslash prefixes from escaped glob characters
  • Added comprehensive test cases for both methods including round-trip testing

These utilities provide the foundation for allowing users to treat glob metacharacters as literals when they appear in actual filenames.

Fixes BEAM-13231

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

This commit adds support for escaping and unescaping glob wildcard characters
in file path specifications, addressing the issue where files with literal
glob metacharacters (*, ?, {, }) in their names cannot be matched.

Changes:
- Added escapeGlobWildcards(String spec) method to escape glob metacharacters
  by prefixing them with backslash
- Added unescapeGlobWildcards(String spec) method to remove backslash prefixes
  from escaped glob characters
- Added comprehensive test cases for both methods including round-trip testing

These utilities provide the foundation for allowing users to treat glob
metacharacters as literals when they appear in actual filenames.

Fixes BEAM-13231
@github-actions github-actions bot added the java label Nov 20, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Arunodoy18, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam SDK's FileSystems utility by adding robust support for handling file paths that contain characters typically interpreted as glob wildcards. By providing explicit methods to escape and unescape these characters, the change ensures that users can specify file names with literal *, ?, {, and } without them being mistakenly treated as pattern-matching wildcards, thereby improving the accuracy and flexibility of file system interactions within Beam.

Highlights

  • New Glob Wildcard Escaping Utilities: Introduced escapeGlobWildcards(String spec) and unescapeGlobWildcards(String spec) methods to FileSystems to handle literal glob metacharacters (*, ?, {, }) in file path specifications.
  • Addresses BEAM-13231: This change resolves the issue where files with literal glob metacharacters in their names could not be correctly matched by treating them as wildcards.
  • Comprehensive Testing: Added extensive test cases for both new methods, including scenarios for escaping, unescaping, and round-trip verification to ensure correctness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Arunodoy18
Copy link
Author

Hi, I'm a first-time contributor.
Could someone please approve the workflows so CI can run?
Also, let me know if I need to fix anything from my side.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant