Skip to content

Change DemoAuthProvider fallback behavior to fit plugin manager changes #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
popduke merged 3 commits into from
Apr 6, 2026
Merged

Change DemoAuthProvider fallback behavior to fit plugin manager changes #239

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eee4e4
1. change DemoAuthProvider fallback behavior to fit new plugin manage…
Gujiawei-Edinburgh Apr 2, 2026
6bc8e1a
1. make fallback plugin completely align with dev only auth plugin;
Gujiawei-Edinburgh Apr 3, 2026
f39ca1b
Merge branch 'main' into fix-demo-auth-plugin
popduke Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 41 additions & 9 deletions build/build-plugin-demo/src/main/java/org/apache/bifromq/demo/plugin/DemoAuthProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@
import java.util.concurrent.CompletableFuture;
import lombok.extern.slf4j.Slf4j;
import org.apache.bifromq.plugin.authprovider.IAuthProvider;
import org.apache.bifromq.plugin.authprovider.type.CheckResult;
import org.apache.bifromq.plugin.authprovider.type.Granted;
import org.apache.bifromq.plugin.authprovider.type.MQTT3AuthData;
import org.apache.bifromq.plugin.authprovider.type.MQTT3AuthResult;
import org.apache.bifromq.plugin.authprovider.type.MQTTAction;
import org.apache.bifromq.plugin.authprovider.type.Reject;
import org.apache.bifromq.plugin.authprovider.type.Ok;
import org.apache.bifromq.type.ClientInfo;
import org.pf4j.Extension;

Expand All @@ -40,7 +42,7 @@ public DemoAuthProvider() {
IAuthProvider delegate1;
String webhookUrl = System.getProperty(PLUGIN_AUTHPROVIDER_URL);
if (webhookUrl == null) {
log.info("No webhook url specified, the fallback behavior will reject all auth/check requests.");
log.info("No webhook url specified, the fallback behavior will grant all auth/check requests.");
delegate1 = new FallbackAuthProvider();
} else {
try {
Expand All @@ -64,20 +66,50 @@ public CompletableFuture<Boolean> check(ClientInfo client, MQTTAction action) {
return delegate.check(client, action);
}

@Override
public CompletableFuture<CheckResult> checkPermission(ClientInfo client, MQTTAction action) {
return delegate.checkPermission(client, action);
}

static class FallbackAuthProvider implements IAuthProvider {
private static final CheckResult GRANTED = CheckResult.newBuilder().setGranted(
Granted.getDefaultInstance()).build();
@Override
public CompletableFuture<MQTT3AuthResult> auth(MQTT3AuthData authData) {
return CompletableFuture.completedFuture(
MQTT3AuthResult.newBuilder().setReject(Reject.newBuilder()
.setCode(Reject.Code.Error)
.setReason("No webhook url for auth provider configured")
.build())
.build());
if (!(authData.getUsername() == null || authData.getUsername().isEmpty())) {
String[] username = authData.getUsername().split("/");
if (username.length == 2) {
return CompletableFuture.completedFuture(MQTT3AuthResult
.newBuilder()
.setOk(Ok.newBuilder()
.setTenantId(username[0])
.setUserId(username[1])
.build())
.build());
} else {
return CompletableFuture.completedFuture(MQTT3AuthResult.newBuilder()
.setOk(Ok.newBuilder()
.setTenantId("DevOnly")
.setUserId(authData.getUsername()).build())
.build());
}
} else {
return CompletableFuture.completedFuture(MQTT3AuthResult.newBuilder()
.setOk(Ok.newBuilder()
.setTenantId("DevOnly")
.setUserId("DevUser").build())
.build());
}
}

@Override
public CompletableFuture<Boolean> check(ClientInfo client, MQTTAction action) {
return CompletableFuture.completedFuture(false);
return CompletableFuture.completedFuture(true);
}

@Override
public CompletableFuture<CheckResult> checkPermission(ClientInfo client, MQTTAction action) {
return CompletableFuture.completedFuture(GRANTED);
}
}
}
Loading