Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize server latency #2886

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number: resolve #2437

Problem Summary:

What is changed and the side effects?

Changed:

  1. 确保耗时不包括用户回调的时间。
  2. 耗时包括异步写的response的时间。

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Jan 31, 2025

看起来改动比较大。是不是重点保证“耗时不包括用户回调的时间”这个就可以?为了实现“耗时包括异步写的response的时间”要增加很多复杂度,包括新引入一个bthread_id,而且可能导致用户升级后观察到的server latency比之前长,容易引起困扰

@chenBright
Copy link
Contributor Author

或者只在span中实现“耗时包括异步写的response的时间“?这样对于排查网络因素导致发送慢response了的问题,应该还是有意义的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

服务端latency统计时间可能有误
2 participants