Skip to content

fix: require full string match in is_uuid4 #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dasokkk wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

fix: require full string match in is_uuid4 #3395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/utility/base_world.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def is_base64(s):

@staticmethod
def is_uuid4(s):
if BaseWorld.re_base64.match(s):
if BaseWorld.re_base64.fullmatch(s):
return True
return False

Expand Down
9 changes: 9 additions & 0 deletions tests/utility/test_base_world.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,12 @@ def test_is_not_base64(self):
def test_is_base64(self):
b64str = 'aGVsbG8gd29ybGQgZnJvbSB1bml0IHRlc3QgbGFuZAo='
assert BaseWorld.is_base64(b64str)

def test_is_uuid4(self):
assert BaseWorld.is_uuid4('a3f1c2d4-5b6e-4f7a-8c9d-0e1f2a3b4c5d')

def test_is_not_uuid4(self):
assert not BaseWorld.is_uuid4('not a uuid')

def test_is_not_uuid4_with_trailing_characters(self):
assert not BaseWorld.is_uuid4('a3f1c2d4-5b6e-4f7a-8c9d-0e1f2a3b4c5d-extra')