CASSANALYTICS-149 Change log level for logs in CassandraSchema to debug level to avoid log spamming#196
Merged
jyothsnakonisa merged 3 commits intoapache:trunkfrom Apr 10, 2026
Merged
Conversation
…ug level to avoid log spamming
Contributor
Author
yifan-c
reviewed
Apr 9, 2026
yifan-c
approved these changes
Apr 9, 2026
Contributor
yifan-c
left a comment
yifan-c
left a comment
There was a problem hiding this comment.
have a nit. +1 in advance
skoppu22
reviewed
Apr 10, 2026
| @NotNull TableIdLookup tableIdLookup) | ||
| { | ||
| LOGGER.info("Updating CDC schema tables='{}'", | ||
| if (LOGGER.isDebugEnabled()) |
Contributor
There was a problem hiding this comment.
Do we need explicit isDebugEnabled check? I believe LOGGER.debug work only when debug enabled right?
Contributor
Author
There was a problem hiding this comment.
Yifan flagged that we do this following computation in the log. Even if debug logging is not enabled it gets computed if we don't have the check. This is an performance optimization
cdcTables.stream()
.map(t -> String.format("%s.%s", t.keyspace(), t.table()))
.collect(Collectors.joining(","))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.