CASSANALYTICS144: Split testing pipelines out#198
Open
jmckenzie-dev wants to merge 14 commits intoapache:trunkfrom
Open
CASSANALYTICS144: Split testing pipelines out#198jmckenzie-dev wants to merge 14 commits intoapache:trunkfrom
jmckenzie-dev wants to merge 14 commits intoapache:trunkfrom
Conversation
Patch by Josh McKenzie, reviewed by TBD for CASSANALYTICS-144 Breaks out tests to parameterize based on specific cassandra versions. Gradle files will be coupled with CassandraVersion.java but both are commented to indicate their interdependency with one another. Also adds some convenience configurations in intellij config so you can select a specific cassandra version to run tests against at runtime or just choose "test" or "testSequential" to run against all supported major cassandra versions.
MultipleTokens test classes use assumeThat(>= 4.1) in @BeforeAll to skip on Cassandra 4.0. When CI runs these individually via --tests, the skipped @BeforeAll leaves zero discovered tests, causing Gradle to fail with "No tests found." Move failOnNoMatchingTests(false) out of the skipContainerTest guard so it applies unconditionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to de-parameterize testing, split out to a representative pre-commit smoke test, and ideally randomize our test ordering reproducibly based on the SHA of the commit we're testing. Oh, and probably tune our resource utilization for integration and unit tests.