Skip to content

CASSANALYTICS-151: Cannot read start offset from BTI with big partitions#199

Open
lukasz-antoniak wants to merge 1 commit intoapache:trunkfrom
lukasz-antoniak:CASSANALYTICS-151
Open

CASSANALYTICS-151: Cannot read start offset from BTI with big partitions#199
lukasz-antoniak wants to merge 1 commit intoapache:trunkfrom
lukasz-antoniak:CASSANALYTICS-151

Conversation

@lukasz-antoniak
Copy link
Copy Markdown
Member

Comment on lines +211 to +213
Arguments.of(100000, 1),
Arguments.of(1000, 100),
Arguments.of(100, 1000)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation is off

Comment on lines +221 to +223
.getPartitioner(partitioner)
.decorateKey((ByteBuffer) ByteBuffer.allocate(4).putInt(index).flip())
.getToken());
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation is off

Comment on lines +221 to +223
.getPartitioner(partitioner)
.decorateKey((ByteBuffer) ByteBuffer.allocate(4).putInt(index).flip())
.getToken());
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation is off

Comment on lines +211 to +213
Arguments.of(100000, 1),
Arguments.of(1000, 100),
Arguments.of(100, 1000)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation is off

Copy link
Copy Markdown
Member

@michaelsembwever michaelsembwever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested, fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants