CASSSIDECAR-419 : Add Docker compose setup for CDC#330
CASSSIDECAR-419 : Add Docker compose setup for CDC#330jyothsnakonisa wants to merge 1 commit intoapache:trunkfrom
Conversation
e4440eb to
65c1f70
Compare
|
|
||
| ## Architecture | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Looks nice, easy to understand for new users
|
|
||
| YAML="/etc/cassandra/cassandra.yaml" | ||
|
|
||
| patch_yaml() { |
There was a problem hiding this comment.
Would it be worth adding a "didn't find it, couldn't patch" style warning or error here?
06c2451 to
1cd0b8d
Compare
1cd0b8d to
11d4fbc
Compare
|
|
||
| WORKDIR /build | ||
|
|
||
| # Build descriptors first — keeps the dependency-download layer cached separately. |
There was a problem hiding this comment.
this is confusing a bit as the user has to do "gradle jar" at least least before this is executed. Without doing "jar", what you copy will not contain "sidecar.version" and then it all passes but it fails to start like this
sidecar-1 | INFO [main] 2026-04-08 16:14:45,333 SidecarSchemaModule.java:59 - Registering table schema: sidecar_internal.restore_range_v1
sidecar-1 | INFO [main] 2026-04-08 16:14:45,333 SidecarSchemaModule.java:59 - Registering table schema: sidecar_internal.restore_slice_v3
sidecar-1 | Exception in thread "main" com.google.inject.ProvisionException: Unable to provision, see the following errors:
sidecar-1 |
sidecar-1 | 1) [Guice/ErrorInCustomProvider]: IllegalStateException: Failed to retrieve Sidecar version from resource /sidecar.version
sidecar-1 | at UtilitiesModule.sidecarVersionProvider(UtilitiesModule.java:88)
sidecar-1 | at ConfigurationModule.instancesMetadata(ConfigurationModule.java:175)
sidecar-1 | \_ for 4th parameter
sidecar-1 | at ConfigurationModule.instancesMetadata(ConfigurationModule.java:175)
sidecar-1 | at InstanceMetadataFetcher.<init>(InstanceMetadataFetcher.java:51)
| # ── Kafka UI ───────────────────────────────────────────────────────────────── | ||
| # Browse topics and messages at http://localhost:8080 | ||
| kafka-ui: | ||
| image: provectuslabs/kafka-ui:latest |
There was a problem hiding this comment.
I suggest we switch to ghcr.io/kafbat/kafka-ui.
That is the fork of provectuslabs, provectuslabs is not longer developed (last change 2 years ago, kafbat is actively developed). Both are Apache licenced. It is same UI etc ...
| # ./scripts/start.sh --clean # build + start, wipe all data | ||
| set -euo pipefail | ||
|
|
||
| # ANSI color codes |
There was a problem hiding this comment.
it would be nice if there is some way to also have "stop" script.
There was a problem hiding this comment.
What am I supposed to do when it is all started and I want to just stop it. Doing docker-compose down on my own? "stop.sh" is more intuitive. "stopping" should also ideally remove the containers, I would like to not see see Exited containers in "docker ps"
|
I suggest to also include this to make it more robust. I like to be explicit in the creation of a topic. If somebody starts the stack and goes to kafka-ui then there will not be any topic for them to see messages in which might be confusing. |
No description provided.