DB Crashes on startup if accord tables exist but accord is disabled #4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the check to validate. This ensures accord flag is checked only during table creation and not during replay. patch by Pranav Shenoy; reviewed David by TBD for CASSANDRA-20600
|
My biggest question is what happens to the server once it starts up. If accord isn't enabled but the tables are marked as accord tables, then don't we have an outage for these tables? |
JeremiahDJordan
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
LGTM. Creation will still fail when queries are sent in, but should not fail node startup.
I would ask someone in the #cassandra-accord channel to be another reviewer here.
@dcapwell I had a chat with @JeremiahDJordan regarding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the check to validate. This ensures accord flag is checked only during table creation and not during replay.
patch by Pranav Shenoy; reviewed David by TBD for CASSANDRA-20600