Trunk accord changes #4204
Closed
Trunk accord changes #4204
+781
−824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore storage compat mode errors
* Fix restart test (Cannot invoke "org.slf4j.Logger.debug(String, Object, Object)" because "this.inInstancelogger" is null)
* Always speculate in accord replacement test to avoid read timeouts
* Make sure not to cleanup fields before persisting them
Background: we would clean up redundantBefore and some other fields.
We are calling persistFieldUpdates, during which we "flush" field updates to command store, but then set it back to null:
fieldUpdates = null;
so when we get to persistFieldUpdatesInternal in AccordTask, we don't have any field updates.
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20718
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20661
…UNSAFE_STARTUP Background: we want to have an escape hatch to pull / copy journal files to investigate locally, but at that stage, we would rather allow the cluster to skip a log entry rather than wipe an entire cluster. Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20702
…ReconstructLogState Patch by Sam Tunnicliffe; reviewed by Alex Petrov for CASSANDRA-20719 Co-authored-by: Sam Tunnicliffe <[email protected]>
Patch by Benedict Elliott Smith; reviewed by Alex Petrov for CASSANDRA-20718
* Make sure to wait for Mutation stage quiesence during replay * Fix visiting same key multiple times during replay Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20675
* Further relax conditions of 'unsafe' startup * Allow skipping unfinished allocations * Relax assertion: allow same key accross multiple different stores * Fix SegmentTest Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20718
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20689
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20718
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20703
… active epochs/topologies Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20702
* Fix typos in AccordDebugKeyspace * Make durability service listen to topology changes * Account for truncated epoch when computing the low bound * Add a test to make sure GC issues do not slip past us in the future * Fix compilation Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20718
…pology can not be fetched Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20716
belliottsmith
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.