-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Stop repair scheduler if two major versions are detected #4372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This follows from #4304. I had to remove the previous branch to perform a clean rebase on top of trunk. CI run - https://pre-ci.cassandra.apache.org/job/cassandra/83/ |
847d39e to
803b20f
Compare
|
This follows from #4304. I messed up the command to force push the new branch onto the existing PR - so I had to create a new PR.
|
803b20f to
46df798
Compare
|
Updated the commit correctly now This follows from #4304. I messed up the command to force push the new branch onto the existing PR - so I had to create a new PR.
|
Do not allow repair scheduler to run repair if two major versions are detected. This can happen during major version upgrade, and we don't want repair to run since the streaming data for repair can be incompatible across major versions. Users can override this using a cassandra yaml config if they want to. Also, this does not affect minor version upgrades, or repair jobs run manually. https://issues.apache.org/jira/browse/CASSANDRA-20048
b5b5a63 to
1ca98b1
Compare
|
Now correctly rebased as well. There is no diff between the two - just that the new commit is a rebase. So previous test run should be good - https://pre-ci.cassandra.apache.org/job/cassandra/85 I have also spun off a new run - https://pre-ci.cassandra.apache.org/job/cassandra/86/ |
|
This PR has been a duplicate of #4304, and we can see that #4304 was already approved by @jaydeepkumar1984 and @tolbertam |
| * Add ELAPSED command to cqlsh (CASSANDRA-18861) | ||
| * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) | ||
| * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) | ||
| * Stop repair scheduler if two major versions are detected (CASSANDRA-20048) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verrrrrry tiny nit: Recent Changes should go at the top instead the bottom of changes for a release.
Do not allow repair scheduler to run repair if two major versions are detected. This can happen during major version upgrade, and we don't want repair to run since the streaming data for repair can be incompatible across major versions.
Users can override this using a cassandra yaml config if they want to.
Also, this does not affect minor version upgrades, or repair jobs run manually.
https://issues.apache.org/jira/browse/CASSANDRA-20048
#4304
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira