[CELEBORN-1793] Add netty pinned memory metrics #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
reviewed
Dec 22, 2024
| "x": 0, | ||
| "y": 39 | ||
| }, | ||
| "id": 226, |
There was a problem hiding this comment.
FYI:
The ids used in #2990 are 226-233.
There was a problem hiding this comment.
If #2990 merged, need to change the ids
There was a problem hiding this comment.
@leixm could you rebase the ids? start from 234.
There was a problem hiding this comment.
FYI: the ids used in #3026 are 234-235.
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This issue was closed because it has been staled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add netty pinned memory metrics
Why are the changes needed?
We can know more accurately the memory actually allocated from PoolArena.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing uts.