[CELEBORN-1838] Interrupt spark task should not report fetch failure #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changes were proposed in this pull request?
Do not trigger fetch failure if a spark task attempt is interrupted(speculation enabled).
Do not trigger fetch failure if the RPC of getReducerFileGroup is timeout.
This PR is intended for celeborn-0.5 branch.
Why are the changes needed?
Avoid unnecessary fetch failures and stage re-runs.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
1. GA.
2. Manually tested on cluster with spark speculation tasks.
Here is the test case
```scala
sc.parallelize(1 to 100, 100).flatMap(i => {
(1 to 150000).iterator.map(num => num)
}).groupBy(i => i, 100)
.map(i => {
if (i._1 < 5) {
Thread.sleep(15000)
}
i
})
.repartition(400).count
```
<img width="1384" alt="截屏2025-01-18 16 16 16" src="https://github.com/user-attachments/assets/adf64857-5773-4081-a7d0-fa3439e751eb" />
<img width="1393" alt="截屏2025-01-18 16 16 22" src="https://github.com/user-attachments/assets/ac9bf172-1ab4-4669-a930-872d009f2530" />
<img width="1258" alt="截屏2025-01-18 16 19 15" src="https://github.com/user-attachments/assets/6a8ff3e1-c1fb-4ef2-84d8-b1fc6eb56fa6" />
<img width="892" alt="截屏2025-01-18 16 17 27" src="https://github.com/user-attachments/assets/f9de3841-f7d4-4445-99a3-873235d4abd0" />
Closes apache#3070 from FMX/branch-0.5-b1838.
Authored-by: mingji <[email protected]>
Signed-off-by: Wang, Fei <[email protected]>
turboFei
commented
Jan 22, 2025
| celebornShuffleId: Int, | ||
| ce: Throwable): Unit = { | ||
| if (ce.getCause != null && | ||
| (ce.getCause.isInstanceOf[InterruptedException] || ce.getCause.isInstanceOf[ |
There was a problem hiding this comment.
Here for the InterruptedException, even #2921 can handle it.
But this PR is more efficient, it do not need to talk with driver and prevent the stage-run for InterruptedException directly.
|
thanks, merging(backport) to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #3070 to main branch.
What changes were proposed in this pull request?
Do not trigger fetch failure if a spark task attempt is interrupted(speculation enabled). Do not trigger fetch failure if the RPC of getReducerFileGroup is timeout. This PR is intended for celeborn-0.5 branch.
Why are the changes needed?
Avoid unnecessary fetch failures and stage re-runs.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
Here is the test case
Closes #3070 from FMX/branch-0.5-b1838.
Authored-by: mingji [email protected]