[CELEBORN-1865] Update master endpointRef when master leader is abnormal #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RexXiong
pushed a commit
that referenced
this pull request
Feb 20, 2025
### What changes were proposed in this pull request? `rpcEndpointRef` should be set to `null` When master leader is not present. ### Why are the changes needed? Attempt master address index can only be updated when `rpcEndpointRef` is `null`. The index wont update if `rpcEndpointRef` has been set but some error ocurs to the master leader. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Closes #3101 from zaynt4606/clb1865. Authored-by: zhengtao <[email protected]> Signed-off-by: Shuang <[email protected]> (cherry picked from commit 27c6605) Signed-off-by: Shuang <[email protected]>
|
Thanks merge to main(v0.6.0) and branch-0.5(v0.5.4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
rpcEndpointRefshould be set tonullWhen master leader is not present.Why are the changes needed?
Attempt master address index can only be updated when
rpcEndpointRefisnull.The index wont update if
rpcEndpointRefhas been set but some error ocurs to the master leader.Does this PR introduce any user-facing change?
No.
How was this patch tested?