Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1857] Support LocalPartitionReader read partition by chunkOffsets when enable optimize skew partition read #3111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wangshengjie123
Copy link
Contributor

@wangshengjie123 wangshengjie123 commented Feb 21, 2025

What changes were proposed in this pull request?

Support LocalPartitionReader read partition by chunkOffsets when enable optimize skew partition read

Why are the changes needed?

In CELEBORN-1319, we have already implemented the skew partition read optimization based on chunk offsets, but we haven't implemented the local partition read. This pull request aims to implement the local partition read.

Does this PR introduce any user-facing change?

When celeborn.client.adaptive.optimizeSkewedPartitionRead.enabled set to true, when read local skew partition files, will read data by chunk offsets.

How was this patch tested?

Current uts and cluster test.

@wangshengjie123 wangshengjie123 changed the title [CELEBORN-1857] Support LocalPartitionReader read partition by chunkOffsets when enable optimize skew partition read [WIP][CELEBORN-1857] Support LocalPartitionReader read partition by chunkOffsets when enable optimize skew partition read Feb 21, 2025
@wangshengjie123 wangshengjie123 changed the title [WIP][CELEBORN-1857] Support LocalPartitionReader read partition by chunkOffsets when enable optimize skew partition read [CELEBORN-1857] Support LocalPartitionReader read partition by chunkOffsets when enable optimize skew partition read Feb 24, 2025
Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wangshengjie123
Copy link
Contributor Author

PTAL, thanks @RexXiong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants