[CELEBORN-1858] Support DfsPartitionReader read partition by chunkOffsets when enable optimize skew partition read #3115
Conversation
Z1Wu
changed the title
| @@ -122,7 +126,7 @@ public DfsPartitionReader( | |||
| e); | |||
| } | |||
|
|
|||
| if (endMapIndex != Integer.MAX_VALUE) { | |||
| if (endMapIndex != Integer.MAX_VALUE && endMapIndex != -1) { | |||
There was a problem hiding this comment.
If the feature of optimizing skew partition read has been enabled, there will be no more sort. So here should not read the sorted DFS file.
The condition should be the condition startMapIndex > endMapIndex to be true and read chunk range from DFS shuffle file.
There was a problem hiding this comment.
In my understanding, currently celeborn supports both sort-based skew-handling and the sort-free skew-handling introduced in #2373. If we change the condition to startMapIndex > endMapIndex, then it will no longer support sort-based skew-handling at all.
There are some other sort-based skew-handling code in current codebase, such as PartitionFilesSorter. If we want to completely remove the code related to sort-based skew-handling, would it be more appropriate to do it in a new PR after #3118 is merged into the main branch?
Please correct me if there's anything I haven't understood correctly.
| @@ -197,7 +211,7 @@ public ByteBuf next() throws IOException, InterruptedException { | |||
| fetchThread.submit( | |||
| () -> { | |||
| try { | |||
There was a problem hiding this comment.
In this catch case, we could avoid to fallback to read SortedPath when optimizing skew partition read is enabled , code
There was a problem hiding this comment.
fixed, PTAL @wangshengjie123
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3115 +/- ##
==========================================
+ Coverage 32.69% 32.69% +0.01%
==========================================
Files 337 338 +1
Lines 20155 20277 +122
Branches 1804 1812 +8
==========================================
+ Hits 6588 6628 +40
- Misses 13201 13281 +80
- Partials 366 368 +2 ☔ View full report in Codecov by Sentry. |
What changes were proposed in this pull request?
Support DfsPartitionReader read partition by chunkOffsets when enable optimize skew partition read
Why are the changes needed?
Follow-up of #2373
Does this PR introduce any user-facing change?
no
How was this patch tested?
test in test-cluster