Skip to content

CI: support run docker build/test on PR #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

CI: support run docker build/test on PR #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a31ae8
CI: support run docker build/test on PR
tuhaihe Oct 20, 2025
513b0ef
Add PR context notification to the Summary
tuhaihe Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/docker-cbdb-build-containers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ on:
- 'devops/deploy/docker/build/rocky8/**'
- 'devops/deploy/docker/build/rocky9/**'
- 'devops/deploy/docker/build/ubuntu22.04/**'
pull_request:
paths:
- 'devops/deploy/docker/build/**'
workflow_dispatch: # Manual trigger

# Prevent multiple workflow runs from interfering with each other
Expand Down Expand Up @@ -116,7 +119,7 @@ jobs:
# Login to DockerHub for pushing images
# Requires DOCKERHUB_USER and DOCKERHUB_TOKEN secrets to be set
- name: Login to Docker Hub
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' }}
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' && github.event_name == 'push' && github.ref == 'refs/heads/main' }}
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USER }}
Expand Down Expand Up @@ -165,7 +168,7 @@ jobs:
# Build and push multi-architecture images
# This creates a manifest list that supports both architectures
- name: Build and Push Multi-arch Docker images
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' }}
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' && github.event_name == 'push' && github.ref == 'refs/heads/main' }}
uses: docker/build-push-action@v6
with:
context: ./devops/deploy/docker/build/${{ matrix.platform }}
Expand All @@ -187,6 +190,18 @@ jobs:
- name: Build Summary
if: always()
run: |
# Add PR context notification
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
echo "#### ℹ️ Pull Request Build" >> $GITHUB_STEP_SUMMARY
echo "This is a validation build. Images are built and tested locally but **not pushed to Docker Hub** for security." >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "- ✅ Dockerfile syntax validated" >> $GITHUB_STEP_SUMMARY
echo "- ✅ Multi-architecture builds tested" >> $GITHUB_STEP_SUMMARY
echo "- ✅ TestInfra tests executed" >> $GITHUB_STEP_SUMMARY
echo "- ⏭️ Docker Hub push skipped (requires main branch)" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
fi

echo "### Build Summary for ${{ matrix.platform }} 🚀" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "#### 🔍 Build Information" >> $GITHUB_STEP_SUMMARY
Expand Down
18 changes: 16 additions & 2 deletions .github/workflows/docker-cbdb-test-containers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ on:
- 'devops/deploy/docker/test/rocky8/**'
- 'devops/deploy/docker/test/rocky9/**'
- 'devops/deploy/docker/test/ubuntu22.04/**'
pull_request:
paths:
- 'devops/deploy/docker/test/**'
workflow_dispatch: # Manual trigger

# Prevent multiple workflow runs from interfering with each other
Expand Down Expand Up @@ -104,7 +107,7 @@ jobs:

# Login to DockerHub for pushing images
- name: Login to Docker Hub
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' }}
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' && github.event_name == 'push' && github.ref == 'refs/heads/main' }}
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USER }}
Expand Down Expand Up @@ -135,7 +138,7 @@ jobs:
# Build and push multi-architecture images
# Creates a manifest list that supports both architectures
- name: Build and Push Multi-arch Docker images
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' }}
if: ${{ steps.platform-filter.outputs[matrix.platform] == 'true' && github.event_name == 'push' && github.ref == 'refs/heads/main' }}
uses: docker/build-push-action@v6
with:
context: ./devops/deploy/docker/test/${{ matrix.platform }}
Expand All @@ -161,6 +164,17 @@ jobs:
- name: Build Summary
if: always()
run: |
# Add PR context notification
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
echo "#### ℹ️ Pull Request Build" >> $GITHUB_STEP_SUMMARY
echo "This is a validation build. Images are built and tested locally but **not pushed to Docker Hub** for security." >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "- ✅ Dockerfile syntax validated" >> $GITHUB_STEP_SUMMARY
echo "- ✅ Multi-architecture builds tested" >> $GITHUB_STEP_SUMMARY
echo "- ⏭️ Docker Hub push skipped (requires main branch)" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
fi

echo "### Build Summary for ${{ matrix.platform }} 🚀" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "#### 🔍 Build Information" >> $GITHUB_STEP_SUMMARY
Expand Down
Loading