Skip to content

Conversation

vishesh92
Copy link
Member

Fixes #68
Changes in these fields is ignored as of now.

@vishesh92 vishesh92 requested a review from Copilot August 26, 2025 08:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for disk offering configuration in CloudStack instance resources by introducing two new optional parameters: disk_offering and override_disk_offering. These fields allow users to specify disk offerings for virtual machines when deploying from templates or ISO images.

Key changes:

  • Added two new optional fields to the instance resource schema with ForceNew behavior
  • Implemented parameter handling in the instance creation logic
  • Added documentation for the new fields explaining their usage with templates vs ISO images

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
website/docs/r/instance.html.markdown Added documentation for the new disk_offering and override_disk_offering parameters
cloudstack/resource_cloudstack_instance.go Added schema definitions and creation logic for the new disk offering fields

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Override root disk offering and Disk Offerings to cloudstack_instance Resource
1 participant