Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The release reserved ip functionality doesn't work from the UI #7965

Open
kiranchavala opened this issue Sep 15, 2023 · 4 comments · May be fixed by #10250
Open

The release reserved ip functionality doesn't work from the UI #7965

kiranchavala opened this issue Sep 15, 2023 · 4 comments · May be fixed by #10250
Assignees
@weizhouapache
Labels
component:UI Severity:Minor type:improvement
Milestone
4.19.2

Comments

@kiranchavala
Copy link
Contributor

kiranchavala commented Sep 15, 2023 •
edited by weizhouapache
Loading

ISSUE TYPE

  • Improvement request

COMPONENT NAME

Component: UI

CLOUDSTACK VERSION

Cloudstack version 4.18

SUMMARY

The release reserved ip functionality doesn't work from the UI if the IP state is Allocated

https://cloudstack.apache.org/api/apidocs-4.18/apis/reserveIpAddress.html

We can display

  • the "Release reserved ip" Icon only when the filter is "Reserved"
  • the "Release IP" icon only when the filter is "Allocated"

Steps to reproduce the issue

  1. Create an isolated network

  2. Aquire some public ip for the network

Network > Guest network > Public Ip address > Aquire ip

Releaseipaddress1

  1. Select some public ip address for the network and click on Release reserved ip

Network > Public Ip address > select some Public ip address for the network > and perform Release reserved ip

Releaseipaddress2

It informs to execute the disassociateIpAddress api call

Releaseipaddress3

https://cloudstack.apache.org/api/apidocs-4.18/apis/disassociateIpAddress.html

https://cloudstack.apache.org/api/apidocs-4.18/apis/releaseIpAddress.html

The api calls works fine


(cmk)  > reserve ipaddress id=87385d0a-fea5-4f04-8894-6f515eb3211e
{
  "ipaddress": {
    "account": "admin",
    "allocated": "2023-09-15T05:55:30+0000",
    "domain": "ROOT",
    "domainid": "c2e4ddb0-5127-11ee-b168-1e00af000354",
    "fordisplay": true,
    "forvirtualnetwork": true,
    "hasannotations": false,
    "id": "87385d0a-fea5-4f04-8894-6f515eb3211e",
    "ipaddress": "10.0.53.227",
    "isportable": false,
    "issourcenat": false,
    "isstaticnat": false,
    "issystem": false,
    "networkid": "b8bd6301-8a5e-4554-80ab-b0d3642f8581",
    "physicalnetworkid": "d1938364-e4cc-4611-8a57-461e4c47bd05",
    "state": "Reserved",
    "tags": [],
    "zoneid": "86d9a63a-3d0b-466f-8f32-81cefc39e31d",
    "zonename": "ref-trl-5653-k-M7-kiran-chavala"
  }
}

(cmk)  > release ipaddress id=87385d0a-fea5-4f04-8894-6f515eb3211e
{
  "success": true
}

The release ipaddress api call fails if the ip address is in allocated state 
For example

(cmk) > release ipaddress id=87385d0a-fea5-4f04-8894-6f515eb3211e

🙈 Error: (HTTP 431, error code 4350) Unable to release a public IP in Allocated state, please use disassociateIpAddress instead
@kiranchavala kiranchavala changed the title The release reserved ip fucntionalty doesn't work from the UI The release reserved ip functionality doesn't work from the UI Sep 15, 2023
@weizhouapache
Copy link
Member

@kiranchavala
by default, the page lists only Allocated public Ips, which can not be released
if you change the filter to Reserved, it will list the Reserved IPs, then the icon will work.

in short, it is expected result.

@kiranchavala
Copy link
Contributor Author

@weizhouapache thanks wei, I missed the filter closing the issue

@kiranchavala
Copy link
Contributor Author

@weizhouapache , i think we can show the release reserved icon only when the reserved filter state is selected

For the allocated ip address we can remove the icon

Screenshot 2023-09-15 at 12 29 55 PM

Screenshot 2023-09-15 at 12 31 18 PM

@kiranchavala kiranchavala reopened this Sep 15, 2023
@weizhouapache
Copy link
Member

@weizhouapache , i think we can show the release reserved icon only when the reserved filter state is selected

For the allocated ip address we can remove the icon

Screenshot 2023-09-15 at 12 29 55 PM

Screenshot 2023-09-15 at 12 31 18 PM

yes, it could be a valid UI improvement request. @kiranchavala

@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone Sep 29, 2023
@rohityadavcloud rohityadavcloud modified the milestones: 4.20.0.0, 4.19.1.0 Apr 30, 2024
@DaanHoogland DaanHoogland modified the milestones: 4.19.1.0, 4.19.2 Jun 18, 2024
@weizhouapache weizhouapache self-assigned this Jun 25, 2024
@weizhouapache weizhouapache moved this from Todo to Dev In Progress in Apache CloudStack BugFest - Issues Aug 19, 2024
weizhouapache added a commit to weizhouapache/cloudstack that referenced this issue Dec 12, 2024
@weizhouapache
UI: support skipGroupAction apache#7965
98e4746
@weizhouapache weizhouapache linked a pull request Jan 23, 2025 that will close this issue
Open
14 tasks
@weizhouapache weizhouapache moved this from Dev In Progress to ready for Review in Apache CloudStack BugFest - Issues Jan 23, 2025
@weizhouapache weizhouapache linked a pull request Jan 23, 2025 that will close this issue
UI: support skipGroupAction #10250
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weizhouapache weizhouapache

Labels
component:UI Severity:Minor type:improvement
Projects
Apache CloudStack BugFest - Issues
Status: ready for Review
Milestone
4.19.2
Development

Successfully merging a pull request may close this issue.

UI: support skipGroupAction weizhouapache/cloudstack
4 participants
@rohityadavcloud @kiranchavala @DaanHoogland @weizhouapache