-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: support skipGroupAction #10250
base: 4.19
Are you sure you want to change the base?
UI: support skipGroupAction #10250
Conversation
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10250 +/- ##
============================================
- Coverage 15.14% 15.14% -0.01%
Complexity 11278 11278
============================================
Files 5408 5408
Lines 473803 473831 +28
Branches 57819 57823 +4
============================================
- Hits 71743 71741 -2
- Misses 394039 394068 +29
- Partials 8021 8022 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Description
This PR fixes #7965 , by skipping actions on some IPs.
This PR also has some changes on group action to start/stop VMs, for example
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?