-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide register template, create/upload volume and create vpc buttons when zone is not created. #10243
base: 4.19
Are you sure you want to change the base?
Conversation
…ton if zone is not created.
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10243 +/- ##
==========================================
Coverage 15.13% 15.14%
- Complexity 11279 11281 +2
==========================================
Files 5408 5408
Lines 474007 473783 -224
Branches 57822 57812 -10
==========================================
+ Hits 71746 71752 +6
+ Misses 394240 394009 -231
- Partials 8021 8022 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@blueorangutan package |
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12178 |
@abh1sar , I think the solution should not be UI only. The API as well should fail at service level, agree? Edit: not that this would not be an improvement. |
@DaanHoogland the 'zone' parameter is required for the api, so the api returns an error if zone is not specified. |
yes, you are right. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can also add:
Images:
- ISOs - register/upload iso
- Kubernetes - Add kub version
Network: - VNF Appliance - add VNF appliance
- s2s VPN - Add VPN GW
- VPN Users - Add User
- VPN Cust Gateway - Add
Storage: - Buckets - create
Compute - Add instance
- Kubernetes - create kub cluster
- autoscale IG - New autoscale IG
- Instance group - new IG
Description
This PR fixes #8145
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?