Fixup alerting and logging error in BGPServiceImpl

[vishesh92]

Description

Fixes:

• NPE when dcId is null or 0L on sending an alert.
• Exception during logging in BGPServiceImpl

Generated summary

This pull request includes several changes to the AlertManagerImpl and BGPServiceImpl classes to improve code clarity and functionality. The most important changes involve the handling of data center IDs and the logging of AS number allocations.

Improvements to AlertManagerImpl:

• server/src/main/java/com/cloud/alert/AlertManagerImpl.java: Added a new variable dcId to handle data center IDs more effectively, replacing direct calls to dataCenter.getId(). [1] [2]

Improvements to BGPServiceImpl:

• server/src/main/java/com/cloud/bgp/BGPServiceImpl.java: Refactored the logging statement in allocateASNumber to use final variables for VpcVO and NetworkVO, improving the readability and ensuring correct variable references.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 16.13%. Comparing base (96b757c) to head (9194370).

Files with missing lines	Patch %	Lines
...er/src/main/java/com/cloud/bgp/BGPServiceImpl.java	0.00%	3 Missing ⚠️
...rc/main/java/com/cloud/alert/AlertManagerImpl.java	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10252   +/-   ##
=========================================
  Coverage     16.13%   16.13%           
  Complexity    12972    12972           
=========================================
  Files          5639     5639           
  Lines        494297   494298    +1     
  Branches      59908    59909    +1     
=========================================
+ Hits          79773    79774    +1     
+ Misses       405698   405697    -1     
- Partials       8826     8827    +1     

Flag	Coverage Δ
uitests	4.02% <ø> (ø)
unittests	16.98% <33.33%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12187

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12188

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12180)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48495 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10252-t12180-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File