Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssvm: reset fields on destroy #10253

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

Description

Fixes #8103

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#8103

Signed-off-by: Abhishek Kumar <[email protected]>
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (9967bb3) to head (4001f76).
Report is 16 commits behind head on 4.19.

Files with missing lines Patch % Lines
.../secondarystorage/SecondaryStorageManagerImpl.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10253      +/-   ##
============================================
+ Coverage     15.13%   15.14%   +0.01%     
- Complexity    11274    11283       +9     
============================================
  Files          5408     5408              
  Lines        473974   473823     -151     
  Branches      57813    57822       +9     
============================================
+ Hits          71730    71764      +34     
+ Misses       394227   394037     -190     
- Partials       8017     8022       +5     
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.86% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwstppr shwstppr marked this pull request as ready for review January 27, 2025 08:22
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants