Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC VR: fix ACL between tier and private gateway #10268

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #9838

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@weizhouapache weizhouapache linked an issue Jan 24, 2025 that may be closed by this pull request
@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (2aa2e92) to head (8d3468e).
Report is 15 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10268      +/-   ##
============================================
+ Coverage     15.14%   15.16%   +0.01%     
- Complexity    11283    11299      +16     
============================================
  Files          5408     5408              
  Lines        473822   473891      +69     
  Branches      57825    57838      +13     
============================================
+ Hits          71762    71860      +98     
+ Misses       394037   393998      -39     
- Partials       8023     8033      +10     
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.88% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 24, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12203

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12186)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45813 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10268-t12186-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

This fixes the issue that SSH/ping does not work from vm in private network to vm in vpc, if
- VPC tier uses ACL default_allow
- private gateway uses ACL "allow egress but deny ingress"
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12276

@weizhouapache
Copy link
Member Author

@blueorangutan test

@weizhouapache weizhouapache marked this pull request as ready for review January 30, 2025 19:25
@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private gateway ACLs are not applied correctly
3 participants