Add `Hypervisor default` as cache mode for disk offerings #10282

hsato03 · 2025-01-27T15:30:12Z

Description

Currently, ACS provides none, write-back and write-through options as cache mode when creating disk offerings.

This PR adds the option Hypervisor default as an alternative to cache mode. By using this option, the KVM hypervisor will choose the cache mode to be used by the disk.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

Disk offering creation

Compute offering with compute only disk offering creation

How Has This Been Tested?

I created a disk offering and a compute offering with compute only disk offering using the Hypervisor default as cache mode;
I deployed a VM for each offering from step 1;
I verified through virt-manager that the disk of both VMs was using the Hypervisor default cache mode, as in the screenshot below.

hsato03 · 2025-01-27T15:33:37Z

@blueorangutan package

blueorangutan · 2025-01-27T15:34:03Z

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-01-27T15:37:50Z

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.50%. Comparing base (5a8a1e2) to head (a0c2a9f).
⚠️ Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...g/apache/cloudstack/storage/to/VolumeObjectTO.java	0.00%	4 Missing ⚠️
...datastore/adapter/ProviderAdapterDiskOffering.java	0.00%	4 Missing ⚠️
...src/main/java/com/cloud/offering/DiskOffering.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #10282   +/-   ##
=========================================
  Coverage     17.50%   17.50%           
- Complexity    15427    15428    +1     
=========================================
  Files          5894     5894           
  Lines        526890   526895    +5     
  Branches      64338    64339    +1     
=========================================
+ Hits          92240    92242    +2     
- Misses       424272   424275    +3     
  Partials      10378    10378

Flag	Coverage Δ
uitests	`3.60% <ø> (ø)`
unittests	`18.56% <10.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-01-27T16:47:38Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12225

github-actions · 2025-01-29T11:28:22Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions · 2025-02-07T12:25:53Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

JoaoJandre · 2025-02-07T14:32:12Z

@hsato03 could you solve the conflicts?

api/src/main/java/com/cloud/offering/DiskOffering.java

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java

...c/main/java/org/apache/cloudstack/storage/datastore/adapter/ProviderAdapterDiskOffering.java

hsato03 · 2025-02-14T20:54:25Z

@blueorangutan package

blueorangutan · 2025-02-14T20:56:03Z

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-02-14T22:02:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12472

hsato03 · 2025-09-26T13:37:04Z

@blueorangutan package

blueorangutan · 2025-09-26T13:38:03Z

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland · 2025-09-26T13:45:48Z

looks good @hsato03 , just the github actions fail. please have a look at that.

blueorangutan · 2025-09-26T14:29:11Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15190

hsato03 · 2025-09-26T15:01:10Z

@blueorangutan package

blueorangutan · 2025-09-26T15:02:06Z

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-26T17:26:24Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15192

blueorangutan · 2025-09-30T09:03:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15232

github-actions · 2025-10-01T13:08:37Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland

clgtm

DaanHoogland · 2025-10-03T07:19:06Z

@hsato03 , you have conflicts. otherwise ready for merge.

weizhouapache

code lgtm

hsato03 · 2025-10-03T12:25:43Z

@blueorangutan package

blueorangutan · 2025-10-03T12:28:03Z

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-03T13:39:29Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15280

blueorangutan · 2025-10-03T19:41:47Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15285

DaanHoogland · 2025-10-06T06:08:48Z

@blueorangutan test

blueorangutan · 2025-10-06T06:10:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-10-06T21:51:59Z

[SF] Trillian test result (tid-14532)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53458 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10282-t14532-kvm-ol8.zip
Smoke tests completed. 145 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_13_retrieve_vr_default_files	`Error`	1.11	test_diagnostics.py
test_14_retrieve_vr_one_file	`Error`	1.10	test_diagnostics.py
test_15_retrieve_ssvm_default_files	`Error`	1.12	test_diagnostics.py
test_16_retrieve_ssvm_single_file	`Error`	1.10	test_diagnostics.py
test_17_retrieve_cpvm_default_files	`Error`	1.11	test_diagnostics.py
test_18_retrieve_cpvm_single_file	`Error`	1.11	test_diagnostics.py
test_01_deployVMInSharedNetwork	`Failure`	523.18	test_network.py

DaanHoogland · 2025-10-07T07:14:16Z

[SF] Trillian test result (tid-14532) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 53458 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10282-t14532-kvm-ol8.zip Smoke tests completed. 145 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_13_retrieve_vr_default_files Error 1.11 test_diagnostics.py
test_14_retrieve_vr_one_file Error 1.10 test_diagnostics.py
test_15_retrieve_ssvm_default_files Error 1.12 test_diagnostics.py
test_16_retrieve_ssvm_single_file Error 1.10 test_diagnostics.py
test_17_retrieve_cpvm_default_files Error 1.11 test_diagnostics.py
test_18_retrieve_cpvm_single_file Error 1.11 test_diagnostics.py
test_01_deployVMInSharedNetwork Failure 523.18 test_network.py

@hsato03 the diagnostics errors are due to shortage on storage that we are suffering but the network error:

======================================================================
FAIL: test_01_deployVMInSharedNetwork (tests.smoke.test_network.TestSharedNetworkWithConfigDrive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/marvin/tests/smoke/test_network.py", line 2395, in test_01_deployVMInSharedNetwork
    self._umount_config_drive(ssh, mount_path)
  File "/marvin/tests/smoke/test_network.py", line 2317, in _umount_config_drive
    self.assertTrue(len(result) == 0,
AssertionError: False is not true : After umount directory should be empty but contains: ['sudo: unable to resolve host VM-1fe596b2-9212-4030-9966-17bc0dfd312b: Temporary failure in name resolution']

I will re-run.

blueorangutan · 2025-10-07T22:26:15Z

[SF] Trillian test result (tid-14547)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51614 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10282-t14547-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py

DaanHoogland · 2025-10-08T11:39:15Z

errors are intermitted and not related

Co-authored-by: Henrique Sato <[email protected]>

Add disk offering Hypervisor default cache mode

e6d1680

boring-cyborg bot added component:api component:kvm component:primary-storage component:storage component:UI labels Jan 27, 2025

github-actions bot added the status:has-conflicts label Jan 29, 2025

Resolve conflicts

5178bad

github-actions bot added status:has-conflicts and removed status:has-conflicts labels Feb 3, 2025

JoaoJandre reviewed Feb 7, 2025

View reviewed changes

hsato03 added 2 commits February 14, 2025 16:44

Resolve conflicts

9275789

Address Joao review

d42432c

github-actions bot removed the status:has-conflicts label Feb 14, 2025

Change ProviderAdapterDiskOffering as well

a20b6d5

JoaoJandre approved these changes Feb 17, 2025

View reviewed changes

sureshanaparti requested a review from weizhouapache June 5, 2025 09:34

sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 14, 2025

Remove unused import

976f2e1

github-actions bot added the status:has-conflicts label Oct 1, 2025

DaanHoogland approved these changes Oct 3, 2025

View reviewed changes

weizhouapache approved these changes Oct 3, 2025

View reviewed changes

Resolve conflicts

a0c2a9f

github-actions bot removed the status:has-conflicts label Oct 3, 2025

DaanHoogland merged commit cc31705 into apache:main Oct 8, 2025
27 of 28 checks passed

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Oct 8, 2025

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025

Add Hypervisor default as cache mode for disk offerings (apache#10282)

26ef05e

Co-authored-by: Henrique Sato <[email protected]>

sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Oct 21, 2025

Add Hypervisor default as cache mode for disk offerings (apache#10282)

39ef8f6

Co-authored-by: Henrique Sato <[email protected]>

Add Hypervisor default as cache mode for disk offerings #10282

Add Hypervisor default as cache mode for disk offerings #10282

Uh oh!

Conversation

hsato03 commented Jan 27, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

hsato03 commented Jan 27, 2025

Uh oh!

blueorangutan commented Jan 27, 2025

Uh oh!

codecov bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jan 27, 2025

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

github-actions bot commented Feb 7, 2025

Uh oh!

JoaoJandre commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hsato03 commented Feb 14, 2025

Uh oh!

blueorangutan commented Feb 14, 2025

Uh oh!

blueorangutan commented Feb 14, 2025

Uh oh!

hsato03 commented Sep 26, 2025

Uh oh!

blueorangutan commented Sep 26, 2025

Uh oh!

DaanHoogland commented Sep 26, 2025

Uh oh!

blueorangutan commented Sep 26, 2025

Uh oh!

hsato03 commented Sep 26, 2025

Uh oh!

blueorangutan commented Sep 26, 2025

Uh oh!

blueorangutan commented Sep 26, 2025

Uh oh!

blueorangutan commented Sep 30, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Oct 3, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

hsato03 commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

DaanHoogland commented Oct 6, 2025

Uh oh!

blueorangutan commented Oct 6, 2025

Uh oh!

blueorangutan commented Oct 6, 2025

Uh oh!

DaanHoogland commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Add `Hypervisor default` as cache mode for disk offerings #10282

Add `Hypervisor default` as cache mode for disk offerings #10282

codecov bot commented Jan 27, 2025 •

edited

Loading