-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hypervisor default
as cache mode for disk offerings
#10282
base: main
Are you sure you want to change the base?
Conversation
@blueorangutan package |
@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10282 +/- ##
=========================================
Coverage 16.02% 16.02%
+ Complexity 13149 13147 -2
=========================================
Files 5658 5658
Lines 496312 496317 +5
Branches 60109 60110 +1
=========================================
+ Hits 79536 79537 +1
- Misses 407927 407931 +4
Partials 8849 8849
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12225 |
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Description
Currently, ACS provides
none
,write-back
andwrite-through
options as cache mode when creating disk offerings.This PR adds the option
Hypervisor default
as an alternative to cache mode. By using this option, the KVM hypervisor will choose the cache mode to be used by the disk.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Disk offering creation
Compute offering with compute only disk offering creation
How Has This Been Tested?
Hypervisor default
as cache mode;virt-manager
that the disk of both VMs was using theHypervisor default
cache mode, as in the screenshot below.