Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api,ui: multi arch improvements #10289

Draft
wants to merge 9 commits into
base: 4.20
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jan 28, 2025

Description

TBA

  • UI changes to display architecture fields for resources.
  • API and UI changes to allow filtering resources using arch

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Signed-off-by: Abhishek Kumar <[email protected]>
Template and ISO list was showing State column as undefined in the
column filter. This PR fixes such cases when the column key is an
object.

Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 6.66667% with 42 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (34d2a3b) to head (ca5dd68).
Report is 3 commits behind head on 4.20.

Files with missing lines Patch % Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 10 Missing ⚠️
...apache/cloudstack/api/response/UserVmResponse.java 33.33% 4 Missing ⚠️
...n/java/com/cloud/resource/SimulatorDiscoverer.java 0.00% 4 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 4 Missing ⚠️
...ack/api/command/admin/cluster/ListClustersCmd.java 0.00% 3 Missing ⚠️
...loudstack/api/command/admin/host/ListHostsCmd.java 0.00% 3 Missing ⚠️
...che/cloudstack/api/command/user/vm/ListVMsCmd.java 0.00% 3 Missing ⚠️
.../java/com/cloud/resource/AgentRoutingResource.java 0.00% 3 Missing ⚠️
.../src/main/java/com/cloud/simulator/MockHostVO.java 0.00% 3 Missing ⚠️
...main/java/com/cloud/api/query/vo/UserVmJoinVO.java 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##               4.20   #10289    +/-   ##
==========================================
  Coverage     16.15%   16.15%            
- Complexity    12976    12986    +10     
==========================================
  Files          5639     5639            
  Lines        494081   494200   +119     
  Branches      59910    59925    +15     
==========================================
+ Hits          79800    79857    +57     
- Misses       405453   405514    +61     
- Partials       8828     8829     +1     
Flag Coverage Δ
uitests 4.02% <ø> (-0.01%) ⬇️
unittests 17.00% <6.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr shwstppr changed the title ui: multi arch improvements api,ui: multi arch improvements Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant