Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add offer ha column to system offerings table #10297

Open
wants to merge 2 commits into
base: 4.20
Choose a base branch
from

Conversation

erik-bock-silva
Copy link

Description

This PR adds a new column to the system offerings listing that shows if HA is enabled or disabled. It includes changes to ListView.vue, which adds a template that handles offerha value from response, and changes to offering.js, that includes the column to the table.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before the changes:

before-column

After the changes:

after-column

How Has This Been Tested?

I've created a test environment with a CloudStack setup, then i built and applied the ui packages to my environment.

Copy link

boring-cyborg bot commented Jan 29, 2025

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@DaanHoogland DaanHoogland added this to the 4.20.1 milestone Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (96b757c) to head (36db58e).
Report is 16 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10297      +/-   ##
============================================
+ Coverage     16.13%   16.15%   +0.02%     
- Complexity    12972    12986      +14     
============================================
  Files          5639     5639              
  Lines        494297   494148     -149     
  Branches      59908    59918      +10     
============================================
+ Hits          79773    79852      +79     
+ Misses       405698   405466     -232     
- Partials       8826     8830       +4     
Flag Coverage Δ
uitests 4.02% <ø> (+<0.01%) ⬆️
unittests 17.00% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10297 (QA-JID-539)

Copy link
Collaborator

@lucas-a-martins lucas-a-martins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested in QA and the System Offering list now shows whether the offering offers HA or not

Perhaps this could be extended to the Compute Offering list, considering that Compute Offerings also have the option to offer HA

Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants