-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add offer ha column to system offerings table #10297
base: 4.20
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10297 +/- ##
============================================
+ Coverage 16.13% 16.15% +0.02%
- Complexity 12972 12986 +14
============================================
Files 5639 5639
Lines 494297 494148 -149
Branches 59908 59918 +10
============================================
+ Hits 79773 79852 +79
+ Misses 405698 405466 -232
- Partials 8826 8830 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested in QA and the System Offering list now shows whether the offering offers HA or not
Perhaps this could be extended to the Compute Offering list, considering that Compute Offerings also have the option to offer HA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Description
This PR adds a new column to the system offerings listing that shows if HA is enabled or disabled. It includes changes to
ListView.vue
, which adds a template that handlesofferha
value from response, and changes tooffering.js
, that includes the column to the table.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before the changes:
After the changes:
How Has This Been Tested?
I've created a test environment with a CloudStack setup, then i built and applied the ui packages to my environment.