Skip to content

kvm, ui: fix interface when using vlan subnet for storage traffic type #11245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jul 18, 2025

Description

Fixes #7816

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

After adding the changes I was able to see new bridge with vlan tag getting created,

# brctl show
bridge name	bridge id		STP enabled	interfaces
breth0-2500		8000.1e0050000c49	no		eth0.2500
							vnet17
breth1-51		8000.020073851163	no		eth1.51
							vnet16
							vnet2
cloud0		8000.fe00a9fe46d2	no		vnet0
							vnet14
cloudbr0		8000.1e0050000c49	yes		eth0
							vnet1
							vnet15
cloudbr1		8000.020073851163	yes		eth1

UI shows VLAN correctly,

image

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (6e19c07) to head (1816aa5).
Report is 23 commits behind head on 4.19.

❗ There is a different number of reports uploaded between BASE (6e19c07) and HEAD (1816aa5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6e19c07) HEAD (1816aa5)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.19   #11245       +/-   ##
=============================================
- Coverage     15.17%    4.28%   -10.90%     
=============================================
  Files          5416      372     -5044     
  Lines        475621    29746   -445875     
  Branches      58054     5230    -52824     
=============================================
- Hits          72168     1274    -70894     
+ Misses       395380    28327   -367053     
+ Partials       8073      145     -7928     
Flag Coverage Δ
uitests 4.28% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant