Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radio buttons in instance migration pop-up #8836

Merged

Conversation

winterhazel
Copy link
Member

Description

When an operator selects the migration mode in the instance migration pop-up, the corresponding radio button does not get checked. This PR fixes this issue.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before the changes

Screenshot from 2024-03-26 11-11-45

After applying these changes

Screenshot from 2024-03-26 11-11-12

How Has This Been Tested?

  1. I created a stopped instance and accessed its page.
  2. I opened the migration pop-up and verified that the first option was selected by default.
  3. I clicked on the second option and verified that its radio button got selected.
  4. I clicked on the first option and verified that its radio button got selected.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.12%. Comparing base (e44c17e) to head (58fd548).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8836      +/-   ##
============================================
+ Coverage     30.93%   31.12%   +0.18%     
- Complexity    33753    34001     +248     
============================================
  Files          5404     5404              
  Lines        380309   380309              
  Branches      55507    55507              
============================================
+ Hits         117658   118370     +712     
+ Misses       247041   246255     -786     
- Partials      15610    15684      +74     
Flag Coverage Δ
simulator-marvin-tests 24.86% <ø> (+0.31%) ⬆️
uitests 4.34% <ø> (ø)
unit-tests 16.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8836 (QA-JID-307)

Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I manually tested in the QA environment:

Before the changes

image

After the changes

image

Copy link
Contributor

@FelipeM525 FelipeM525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working fine! CLGTM!

Before

image

After

image

@DaanHoogland DaanHoogland merged commit 77cc75a into apache:main Jul 13, 2024
25 checks passed
@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone Jul 15, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 23, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants