make server threads configurable with server.properties file

[ahmedali6]

Description

Fixes: #9161

Types of changes

• Enhancement (improves an existing feature and functionality)

Feature/Enhancement Scale

• Minor

How Has This Been Tested?

Tested manually by building and running the server.

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.32%. Comparing base (cb9b313) to head (de779c3).
Report is 529 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9260      +/-   ##
============================================
- Coverage     15.32%   15.32%   -0.01%     
  Complexity    11687    11687              
============================================
  Files          5459     5459              
  Lines        477294   477294              
  Branches      62055    59052    -3003     
============================================
- Hits          73140    73138       -2     
- Misses       396074   396076       +2     
  Partials       8080     8080              

Flag	Coverage Δ
uitests	4.19% <ø> (ø)
unittests	16.07% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9978

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10321

[DaanHoogland]

@blueorangutan test alma9 kvm-alma9

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10805)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 55648 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9260-t10805-kvm-alma9.zip
Smoke tests completed. 135 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_06_purge_expunged_vm_background_task	Failure	331.49	test_purge_expunged_vms.py
test_01_redundant_vpc_site2site_vpn	Failure	470.34	test_vpc_vpn.py
test_01_vpc_site2site_vpn	Failure	325.52	test_vpc_vpn.py

[DaanHoogland]

clgtm

[JoaoJandre]

LGTM, did not test it

[JoaoJandre]

This is a small a nitpick, but you don't need to initialize these values, as in the properties.getProperty call you already inform these as default.

[DaanHoogland]

will you change this @ahmedali6 ? No big deal if you don't, but if you do, you can also comment out the new properties for the same reason.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[shwstppr]

code LGTM (w/ a minor comment)

[shwstppr]

minor - too many places we are setting the default value. This could have been a comment

[shwstppr]

@ahmedali6 can you please address the comments and resolve conflicts?

[sureshanaparti]

hi @ahmedali6 can you check/address the outstanding comments, and resolve the conflicts.