Skip to content

test_primary_storage_scope.py should only run with kvm, vmware and simulator #9323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Jul 1, 2024

Description

This PR fixes the smoke failure in test_primary_storage_scope.py when run with XenServer.
#9315

[SF] Trillian test result (tid-10688)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41254 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t10688-xenserver-71.zip
Smoke tests completed. 131 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_primary_storage_scope_change	Error	0.07	test_primary_storage_scope.py

Zone wide storage pools are not supported with Xenserver so storage pool creation was failing during setup, and not cleaning up the created cluster.
This causes cluster create to fail if the test is retried.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Jul 1, 2024
@abh1sar abh1sar self-assigned this Jul 1, 2024
@abh1sar abh1sar requested a review from sureshanaparti July 1, 2024 14:05
@abh1sar
Copy link
Collaborator Author

abh1sar commented Jul 1, 2024

@blueorangutan package

@blueorangutan
Copy link

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.05%. Comparing base (d797356) to head (e28e40f).

Additional details and impacted files
@@            Coverage Diff             @@
##               4.19    #9323    +/-   ##
==========================================
  Coverage     15.05%   15.05%            
- Complexity    11135    11138     +3     
==========================================
  Files          5405     5405            
  Lines        472353   472353            
  Branches      61429    60748   -681     
==========================================
+ Hits          71110    71129    +19     
+ Misses       393324   393302    -22     
- Partials       7919     7922     +3     
Flag Coverage Δ
uitests 4.27% <ø> (ø)
unittests 15.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10227

@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone Jul 1, 2024
@abh1sar
Copy link
Collaborator Author

abh1sar commented Jul 1, 2024

@blueorangutan test matrix

@blueorangutan
Copy link

@abh1sar a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-10702)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-10704)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-10703)

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-10714)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-10715)

@abh1sar
Copy link
Collaborator Author

abh1sar commented Jul 3, 2024

@blueorangutan package

@blueorangutan
Copy link

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

[SF] Trillian test result (tid-10716)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47478 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9323-t10716-kvm-centos7.zip
Smoke tests completed. 130 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_cancel_host_maintenace_with_migration_jobs Error 221.03 test_host_maintenance.py
test_hostha_kvm_host_fencing Error 115.74 test_hostha_kvm.py

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10235

@sureshanaparti
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@apache apache deleted a comment from blueorangutan Jul 3, 2024
@blueorangutan
Copy link

[SF] Trillian test result (tid-10719)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9323-t10719-xenserver-71.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[SF] Trillian test result (tid-10720)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48510 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9323-t10720-vmware-67u3.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti merged commit 79b1427 into apache:4.19 Jul 4, 2024
25 of 26 checks passed
@abh1sar abh1sar deleted the scope-test branch July 4, 2024 08:58
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
…mulator (apache#9323)

* test_primary_storage_scope should only run with kvm, vmware and simulator

* move cluster create and storage pool create from setup to test so that they are cleaned up in case of failure

* fixed lint failure

* using super class' tearDown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:integration-test Python Warning... Python code Ahead!
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants