Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix CreateIsolatedNetworkForm.vue #9359

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes the CreateIsolatedNetworkForm.vue in main/4.20 branch.

Due to PR #8919 , the PR #9348 should be ignored in main/4.20 branch.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.20.0.0 milestone Jul 9, 2024
@weizhouapache weizhouapache requested a review from Pearl1594 July 9, 2024 06:44
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.17%. Comparing base (0af8835) to head (dad8f11).

❗ There is a different number of reports uploaded between BASE (0af8835) and HEAD (dad8f11). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0af8835) HEAD (dad8f11)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #9359       +/-   ##
============================================
- Coverage     15.53%   4.17%   -11.37%     
============================================
  Files          5492     371     -5121     
  Lines        480931   30420   -450511     
  Branches      61853    5390    -56463     
============================================
- Hits          74711    1269    -73442     
+ Misses       397959   29007   -368952     
+ Partials       8261     144     -8117     
Flag Coverage Δ
uitests 4.17% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@rohityadavcloud rohityadavcloud merged commit 354627a into apache:main Jul 9, 2024
22 of 25 checks passed
@DaanHoogland DaanHoogland deleted the 4.20-fix-CreateIsolatedNetworkForm.vue branch July 9, 2024 08:17
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants