-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Switch back to CLOUD_DB after purging usage records #9367
Fix: Switch back to CLOUD_DB after purging usage records #9367
Conversation
@blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #9367 +/- ##
==========================================
Coverage 12.25% 12.26%
- Complexity 9318 9321 +3
==========================================
Files 4699 4699
Lines 414601 414603 +2
Branches 51421 51693 +272
==========================================
+ Hits 50829 50842 +13
+ Misses 357461 357448 -13
- Partials 6311 6313 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10322 |
engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java
Outdated
Show resolved
Hide resolved
engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java
Outdated
Show resolved
Hide resolved
engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d64b75a
to
86c4313
Compare
@blueorangutan package |
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10335 |
@blueorangutan test |
@borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
[SF] Trillian Build Failed (tid-10816) |
[SF] Trillian test result (tid-10815)
|
Description
Executing
removeRawUsageRecords
command results in Management server becoming unavailable and random failure of subsequent requests. This PR fixes the issue by switching back to CLOUD_DB after the records have been removed from the database.Steps to reproduce
Execute
cmk removeRawUsageRecords interval=1000
. Requests to the management server will start failing after that.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?