Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-managed pools for storage pool access preparation #9376

Merged

Conversation

sureshanaparti
Copy link
Contributor

Description

This PR ignores non-managed pools for storage pool access preparation.

Fixes #9371

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone Jul 12, 2024
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@weizhouapache
Copy link
Member

the logic looks good to me
thanks @sureshanaparti

@rohityadavcloud rohityadavcloud changed the base branch from main to 4.19 July 12, 2024 07:08
@rohityadavcloud
Copy link
Member

@sureshanaparti base branch was wrong, fixed to 4.19 now

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.17%. Comparing base (32cc1d4) to head (397e457).

❗ There is a different number of reports uploaded between BASE (32cc1d4) and HEAD (397e457). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (32cc1d4) HEAD (397e457)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #9376       +/-   ##
============================================
- Coverage     15.07%   4.17%   -10.91%     
============================================
  Files          5405     371     -5034     
  Lines        472672   30420   -442252     
  Branches      58189    5390    -52799     
============================================
- Hits          71257    1269    -69988     
+ Misses       393486   29007   -364479     
+ Partials       7929     144     -7785     
Flag Coverage Δ
uitests 4.17% <ø> (-0.11%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohityadavcloud
Copy link
Member

Tested in my homelab LGTM

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10333

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test matrix

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-10812)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43890 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9376-t10812-xenserver-71.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[SF] Trillian test result (tid-10813)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47424 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9376-t10813-vmware-67u3.zip
Smoke tests completed. 130 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_list_system_vms_metrics_history Failure 0.25 test_metrics_api.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-10814)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53683 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9376-t10814-kvm-centos7.zip
Smoke tests completed. 130 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_secured_to_nonsecured_vm_migration Error 375.49 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 394.31 test_vm_life_cycle.py
test_04_deploy_vnf_appliance Error 92.45 test_vnf_templates.py
test_04_deploy_vnf_appliance Error 92.46 test_vnf_templates.py
test_05_delete_vnf_template Error 1.08 test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown Error 2.18 test_vnf_templates.py

@sureshanaparti sureshanaparti marked this pull request as ready for review July 14, 2024 09:19
@sureshanaparti sureshanaparti merged commit d9f77b8 into apache:4.19 Jul 14, 2024
26 of 27 checks passed
@DaanHoogland DaanHoogland deleted the non-managed-pool-and-host-access-fix branch July 14, 2024 13:58
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 23, 2024
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Sep 5, 2024
* Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver (apache#9310)

* Ignore non-managed pools for storage pool access preparation (apache#9376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CPVM/SSVM fails to start on KVM/Ubuntu 22.04 with 4.19.1 RC1 using local storage
4 participants