saml: purge token after first response and improve setting description #9377
Conversation
This improves the description of a saml signature checking global setting, and purges the SAML token upon handling the first SAML response. Signed-off-by: Rohit Yadav <[email protected]>
rohityadavcloud
requested review from
shwstppr,
DaanHoogland,
sureshanaparti and
weizhouapache
|
@blueorangutan package |
|
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
| @@ -228,6 +228,7 @@ public String authenticate(final String command, final Map<String, Object[]> par | |||
| "Received SAML response for a SSO request that we may not have made or has expired, please try logging in again", | |||
| params, responseType)); | |||
| } | |||
| samlAuthManager.purgeToken(token); | |||
There was a problem hiding this comment.
this isn't very useful for now; but potentially guards against any replays
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9377 +/- ##
==========================================
Coverage 15.07% 15.08%
- Complexity 11166 11173 +7
==========================================
Files 5405 5405
Lines 472672 472677 +5
Branches 58189 58295 +106
==========================================
+ Hits 71257 71283 +26
+ Misses 393486 393464 -22
- Partials 7929 7930 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rohit Yadav <[email protected]>
|
@blueorangutan package |
|
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10334 |
|
unit test failure :( , trying locally. |
the unit test with |
|
Yup it’s failure on 4.19 branch, anyone fixing it? |
|
it compiles without issues locally |
|
@blueorangutan package |
|
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Seems like I didn't wait enough while reopening the PR to kick GH actions. Trying again |
|
Or maybe it was my mobile app 🤦 |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10345 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-10827)
|
apache#9377) * saml: purge token after first response and improve setting description This improves the description of a saml signature checking global setting, and purges the SAML token upon handling the first SAML response. Signed-off-by: Rohit Yadav <[email protected]> * fix failing unit test Signed-off-by: Rohit Yadav <[email protected]> --------- Signed-off-by: Rohit Yadav <[email protected]>
This improves the description of a saml signature checking global setting, and purges the SAML token upon handling the first SAML response.
Types of changes
Testing
The community QA server is applied with these changes to test the SAML SSO with the
rickuser https://qa.cloudstack.cloud/simulator