Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: copy to clipboard console url for safari #9378

Closed

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Jul 12, 2024

Description

This PR fixes #9368

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@vishesh92 vishesh92 changed the title Fix copy to clipboard for safari Fix: copy to clipboard console url for safari Jul 12, 2024
@vishesh92 vishesh92 changed the base branch from main to 4.19 July 12, 2024 09:08
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.27%. Comparing base (32cc1d4) to head (b62922a).

❗ There is a different number of reports uploaded between BASE (32cc1d4) and HEAD (b62922a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (32cc1d4) HEAD (b62922a)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #9378       +/-   ##
============================================
- Coverage     15.07%   4.27%   -10.81%     
============================================
  Files          5405     365     -5040     
  Lines        472672   29501   -443171     
  Branches      58189    5162    -53027     
============================================
- Hits          71257    1261    -69996     
+ Misses       393486   28097   -365389     
+ Partials       7929     143     -7786     
Flag Coverage Δ
uitests 4.27% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92 vishesh92 force-pushed the fix-copy-to-clipboard-safari branch from 9a557a9 to b62922a Compare July 12, 2024 09:13
@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9378 (QA-JID-400)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy works on both FF and Chrome on linux

@DaanHoogland
Copy link
Contributor

I suppose you tested on Safari @rohityadavcloud ?

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9378 (QA-JID-401)

@rohityadavcloud
Copy link
Member

sorry doesn't work @vishesh92 cc @DaanHoogland

@vishesh92
Copy link
Member Author

Covered in #9381

@vishesh92 vishesh92 closed this Jul 12, 2024
@vishesh92 vishesh92 deleted the fix-copy-to-clipboard-safari branch July 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy console UI button does not work
4 participants