-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: copy to clipboard console url for safari #9378
Conversation
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9378 +/- ##
============================================
- Coverage 15.07% 4.27% -10.81%
============================================
Files 5405 365 -5040
Lines 472672 29501 -443171
Branches 58189 5162 -53027
============================================
- Hits 71257 1261 -69996
+ Misses 393486 28097 -365389
+ Partials 7929 143 -7786
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9a557a9
to
b62922a
Compare
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy works on both FF and Chrome on linux
I suppose you tested on Safari @rohityadavcloud ? |
UI build: ✔️ |
sorry doesn't work @vishesh92 cc @DaanHoogland |
Covered in #9381 |
Description
This PR fixes #9368
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?