-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Set CORS headers for both http/https in SSVM apache config #9389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good , thanks @salfers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9389 +/- ##
============================================
- Coverage 15.54% 15.54% -0.01%
Complexity 11976 11976
============================================
Files 5493 5493
Lines 481030 481030
Branches 60247 60998 +751
============================================
- Hits 74766 74764 -2
- Misses 398000 398003 +3
+ Partials 8264 8263 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I just noticed that removing |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10635 |
@blueorangutan test |
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-11071)
|
@DaanHoogland any news? |
needs another review and some 3rd person testing, @salfers . |
@weizhouapache , can you have a look at this? |
@DaanHoogland |
not like that of course (duh?) |
Description
This PR sets the necessary CORS headers on the SSVM independently of protocol.
Fixes: #9366
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?
I have not tested this.
If you have any advice how I can properly test changes made to system VMs, please let me know.