Skip to content

Set CORS headers for both http/https in SSVM apache config #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

salfers
Copy link

@salfers salfers commented Jul 15, 2024

Description

This PR sets the necessary CORS headers on the SSVM independently of protocol.

Fixes: #9366

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

I have not tested this.
If you have any advice how I can properly test changes made to system VMs, please let me know.

Copy link

boring-cyborg bot commented Jul 15, 2024

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good , thanks @salfers

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.54%. Comparing base (afdf4d7) to head (a297c4f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9389      +/-   ##
============================================
- Coverage     15.54%   15.54%   -0.01%     
  Complexity    11976    11976              
============================================
  Files          5493     5493              
  Lines        481030   481030              
  Branches      60247    60998     +751     
============================================
- Hits          74766    74764       -2     
- Misses       398000   398003       +3     
+ Partials       8264     8263       -1     
Flag Coverage Δ
uitests 4.16% <ø> (ø)
unittests 16.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salfers
Copy link
Author

salfers commented Jul 16, 2024

I just noticed that removing useHttpsToUpload entirely could affect other code. I got rid of that now.

@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@apache apache deleted a comment from blueorangutan Aug 13, 2024
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10635

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11071)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50927 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9389-t11071-kvm-ol8.zip
Smoke tests completed. 138 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 406.05 test_vm_life_cycle.py

@salfers
Copy link
Author

salfers commented Oct 15, 2024

@DaanHoogland any news?

@weizhouapache weizhouapache modified the milestones: 4.19.2.0, 4.20.1.0 Oct 15, 2024
@DaanHoogland
Copy link
Contributor

@DaanHoogland any news?

needs another review and some 3rd person testing, @salfers .

@DaanHoogland
Copy link
Contributor

@weizhouapache , can you have a look at this?

@weizhouapache
Copy link
Member

@DaanHoogland
the author @salfers mentioned I have not tested this., are we going to merge it ?

@DaanHoogland
Copy link
Contributor

@DaanHoogland the author @salfers mentioned I have not tested this., are we going to merge it ?

not like that of course (duh?)

@vladimirpetrov vladimirpetrov self-assigned this Jan 22, 2025
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@Pearl1594 Pearl1594 removed this from ACS 4.20.1 Jun 3, 2025
@Pearl1594 Pearl1594 modified the milestones: 4.20.1, 4.20.2 Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSVM should set correct headers on both HTTP and HTTPS
6 participants