Skip to content

Conversation

@jfclere
Copy link
Contributor

@jfclere jfclere commented May 28, 2025

Make the prunsrv.exe available as artifact.

@jfclere jfclere merged commit e6331de into apache:master Jun 6, 2025
14 checks passed
@jfclere
Copy link
Contributor Author

jfclere commented Jul 18, 2025

the artifact needs vcruntime140.dll

@markt-asf
Copy link
Contributor

-1 (almost veto). This absolutely should not be necessary. If it is, the binary hasn't been built properly. Which binary were you testing with? I thought I'd tested the most recently released binaries on a clean OS install without issue. Did I miss something? Which OS version were you testing on?

@jfclere
Copy link
Contributor Author

jfclere commented Jul 21, 2025

I tested on a clean 2025 server install, copy the executable and noted that it needs vcruntime140.dll.
Having the executable available makes testing on different OS version more easy.

@markt-asf
Copy link
Contributor

Where did you get the binary from?

@jfclere
Copy link
Contributor Author

jfclere commented Jul 21, 2025

From the artifact.
Note #271 that makes a static binary.

@markt-asf
Copy link
Contributor

Sorry. Let me step back a bit. Is this binary from a release (if so which one) or a CI output?

@jfclere
Copy link
Contributor Author

jfclere commented Jul 21, 2025

It is a from a CI output.

@markt-asf
Copy link
Contributor

OK. I'm less concerned then. That said, that suggests the CI build isn't building the binary correctly. I'd suggest fixing that rather than adding the dll so potential issues are not masked. The risk is we break something in the build, don't notice as the CI build masks it because the dll is included and the issue then makes it into a release build before we notice.

@jfclere
Copy link
Contributor Author

jfclere commented Jul 21, 2025

OK I am on it ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants