Skip to content

doc(plugin): notes for --link when the linking is lost #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GitToTheHub
Copy link
Contributor

  • Added notice, that the linking only works, when the plugin is added after a platform was added and that the linking will be lost if a platform is re-added or a project is restored
  • Added link to "Version management" to explain what restoring a project means and add cordova prepare to give an example also

Platforms affected

All

Motivation and Context

It was not clear, that the plugin linking will be lost, if a platform is re-added or a project is restored

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- Added notice, that the linking only works, when the plugin is added after a platform was added and that the linking will be lost if a platform is re-added or a project is restored
- Added link to "Version management" to explain what restoring a project means and add `cordova prepare` to give an example also
@erisu
Copy link
Member

erisu commented Jun 9, 2025

@GitToTheHub
Copy link
Contributor Author

Sure no problem, I will add it 🙂

- Added notice, that the linking only works, when the plugin is added after a platform was added and that the linking will be lost if a platform is re-added or a project is restored
- Added link to "Version management" to explain what restoring a project means and add `cordova prepare` to give an example also
- Added to 12.x-2025.01 and dev
@GitToTheHub
Copy link
Contributor Author

I added it but had some problems with git. Should I reopen this pr with one commit?

@erisu
Copy link
Member

erisu commented Jun 9, 2025

It is OK if there is multiple commits in the PR. When we merge the PR, we use the "Squash and merge" option to make a single commit.

@erisu erisu changed the title Plugin Guide: Notes for --link option when the linking will be lost doc(plugin): notes for --link when the linking is lost Jun 9, 2025
@GitToTheHub
Copy link
Contributor Author

Oh ok I have to learn some things still :) I know this option, but was not using it very often. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants