Skip to content

Conversation

kumo01GitHub
Copy link
Contributor

@kumo01GitHub kumo01GitHub commented Dec 31, 2024

Platforms affected

iOS, browser

Motivation and Context

Cordova version is set in Objective-C and JavaScript but only use JavaScript as README.

The version information comes from the cordova.js file.

Description

Remove Objective-C method.

Testing

Tested with Simulator.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@kumo01GitHub
Copy link
Contributor Author

kumo01GitHub commented Dec 31, 2024

related issue #101

I saw the comment but device.js doesn't refer to info.cordova.

(Note: https://issues.apache.org/jira/browse/CB-5105 says "iOS is doing something special, but doing it right, so don't make any changes to iOS." but no idea what that refers to)

var buildLabel = cordova.version;

@kumo01GitHub kumo01GitHub force-pushed the refactor/remove-unusedmethod branch from e437176 to 96183dc Compare May 3, 2025 17:06
@kumo01GitHub kumo01GitHub force-pushed the refactor/remove-unusedmethod branch from 96183dc to b84096e Compare May 10, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant